DYN-1476 Follow Up: Remove Rank Reduction from Dictionary.Values #9550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d debug menu. Deleted debug menu items.
Member
|
👍 LGTM |
scottmitchell
added a commit
to scottmitchell/Dynamo
that referenced
this pull request
Mar 8, 2019
…amoDS#9550) * update * Brought truncated search results and full query search out from behind debug menu. Deleted debug menu items. * Removed AllowRankReduction from Dictionary.Values. Added TODO
scottmitchell
added a commit
that referenced
this pull request
Mar 8, 2019
…rties (#9542) (#9549) * DYN-1476: AllowRankReductionAttribute on Zero Touch seems to be broken (#9542) * update * Brought truncated search results and full query search out from behind debug menu. Deleted debug menu items. * Added CheckForRankReductionAttribute() method to FFIMemberInfo * Cleaned up CheckForRankReductionAttribute * Added AllowRankReductionAttribute tests * Comments. Change method name. * Update tests, method name * Corrected test names * Fixed annoying diff * DYN-1476 Follow Up: Remove Rank Reduction from Dictionary.Values (#9550) * update * Brought truncated search results and full query search out from behind debug menu. Deleted debug menu items. * Removed AllowRankReduction from Dictionary.Values. Added TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR follows up on DYN-1476, which fixed the
AllowRankReductionAttributeon zero touch properties. This fix caused the behavior ofDictionary.Valuesto change, and broke a test that used that property. This PR removesAllowRankReductionAttributefromDictionary.Values. We will consider adding it back for 3.0.Declarations
Check these if you believe they are true
*.resxfilesFYIs
@aparajit-pratap @mjkkirschner @QilongTang @smangarole