Skip to content

Revert partial fix to heterogeneous lists #9429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
Jan 15, 2019
Merged

Revert partial fix to heterogeneous lists #9429

QilongTang merged 2 commits into from
Jan 15, 2019

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jan 15, 2019 •
edited
Loading

Purpose

This PR partially reverts #9408 as it caused timeout failures with the following Revit tests:

The aborted regression failures:AddIns\Dynamo\SystemTests\Workflow\Test_PerforationsByImage.txt
ABORTED[TimedOut]    Journal Other Failures...
AddIns\Dynamo\SystemTests\Workflow\Vignette_04_Deviation.txt
ABORTED[TimedOut]    Journal Other Failures...
AddIns\Dynamo\SystemTests\Workflow\Vignette_04_Solar.txt
ABORTED[TimedOut]    Journal Other Failures...

It the Revit tests pass after this is merged, we need to release note the heterogeneous list cases that do not work in 2.1.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

FYIs

@mjkkirschner @reddyashish @QilongTang @smangarole

@QilongTang QilongTang merged commit 21f8d2b into DynamoDS:RC2.1.0_master Jan 15, 2019
aparajit-pratap added a commit to aparajit-pratap/Dynamo that referenced this pull request Jan 18, 2019
@aparajit-pratap
Revert partial fix to heterogeneous lists (DynamoDS#9429)
70e1039 
* revert partial fix to heterogeneous lists

* mark failing tests
@aparajit-pratap aparajit-pratap mentioned this pull request Jan 18, 2019
Merged
7 tasks
aparajit-pratap added a commit that referenced this pull request Jan 18, 2019
@aparajit-pratap
Cherr-pick revert of heterogeneous list fix and add workflow test tha…
ae68a86 
…t highlights performance degradation (#9441)

* Revert partial fix to heterogeneous lists (#9429)

* revert partial fix to heterogeneous lists

* mark failing tests

* revert fix due to perf degradation, add perf test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aparajit-pratap @QilongTang