Skip to content

Cherry-pick DYN1198- Heterogeneous list update gives infinite loop (#9408) #9415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Jan 14, 2019
Merged

Cherry-pick DYN1198- Heterogeneous list update gives infinite loop (#9408) #9415

QilongTang merged 1 commit into from
Jan 14, 2019

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jan 13, 2019 •
edited
Loading

  • Heterogenous list crash fix

  • Adding test case for heterogeneous list crash

  • Adding tests

  • Adding new test

  • fix remaining edge cases

  • revert assemblysharedinfo file

  • Updating failing tests

  • add new method to prevent API break

  • simplify SelectMany

Purpose

Cherry-pick #9408

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

FYIs

@QilongTang
@mjkkirschner
@reddyashish

@reddyashish @aparajit-pratap
DYN1198- Heterogeneous list update gives infinite loop (DynamoDS#9408)
e7e9388 
* Heterogenous list crash fix

* Adding test case for heterogeneous list crash

* Adding tests

* Adding new test

* fix remaining edge cases

* revert assemblysharedinfo file

* Updating failing tests

* add new method to prevent API break

* simplify SelectMany
@aparajit-pratap aparajit-pratap changed the title DYN1198- Heterogeneous list update gives infinite loop (#9408) Cherry-pick DYN1198- Heterogeneous list update gives infinite loop (#9408) Jan 13, 2019
@aparajit-pratap aparajit-pratap mentioned this pull request Jan 13, 2019
Merged
7 tasks
@mjkkirschner
Copy link
Member

mjkkirschner commented Jan 13, 2019

when I have a chance to - will kick off another eng ops build - it's probably just failing because it still tries to merge this code to the master branch, gotta rebuild it with the right parameters.

@QilongTang
Copy link
Contributor

QilongTang commented Jan 14, 2019

Restarted PR build, will merge once it pass. This should be last PR to RC2.1.0_master

@QilongTang QilongTang merged commit 5ddd3d5 into DynamoDS:RC2.1.0_master Jan 14, 2019
@aparajit-pratap aparajit-pratap deleted the hetero2.1 branch January 14, 2019 01:16
reddyashish added a commit that referenced this pull request Jan 14, 2019
@reddyashish
Revert "DYN1198- Heterogeneous list update gives infinite loop (#9408) (
46039f8 
#9415)"

This reverts commit 5ddd3d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aparajit-pratap @mjkkirschner @QilongTang @reddyashish