Skip to content

Selective shift + click operation #7900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yeexinc wants to merge 3 commits into from
Closed

Selective shift + click operation #7900

yeexinc wants to merge 3 commits into from

Conversation

@yeexinc
Copy link
Contributor

@yeexinc yeexinc commented May 25, 2017

Purpose

When the user has some nodes in their selection, the shift + click operation will only be done on the selected nodes.
selectiveshift

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@riteshchandawar

@Racel
Copy link
Contributor

Racel commented Jul 18, 2017

@QilongTang - Similar to #7850. We will need to do the review and merge. Adding a task for this in our backlog.

alfarok added a commit to alfarok/Dynamo that referenced this pull request Mar 15, 2019
@alfarok
pull in and clean up DynamoDS#7900
862cc63
alfarok added a commit to alfarok/Dynamo that referenced this pull request Mar 18, 2019
@alfarok
Add recorded tests to cover work done originally in DynamoDS#7900
56d8e89
@alfarok alfarok mentioned this pull request Mar 18, 2019
Merged
7 tasks
@alfarok
Copy link
Contributor

alfarok commented Mar 18, 2019

closing and picking this work up in #9585

@alfarok alfarok closed this Mar 18, 2019
alfarok added a commit that referenced this pull request Mar 19, 2019
@alfarok
Selective shift + click output connections grabs connectors for selec…
d442504 
…ted nodes only (#9585)

* pull in and clean up #7900

* Add recorded tests to cover work done originally in #7900

* remove duplicate logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riteshchandawar riteshchandawar Awaiting requested review from riteshchandawar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yeexinc @Racel @alfarok