DYN-9774: [Cherry-pick] Complete PythonNet3 + .Net10 final Update to 4.0 #16692
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9774
There was a problem hiding this comment.
Pull Request Overview
This PR refactors toast notification functionality by extracting it from GuidesManager into a dedicated ToastManager class and implements a 3-second auto-close timer for all toast notifications.
Key Changes:
- Created new
ToastManagerclass to handle toast notifications independently from guided tour functionality - Added automatic 3-second timeout for all toast notifications
- Updated all references from
MainGuideManagertoToastManagerthroughout the codebase
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DynamoCoreWpf/UI/ToastManager.cs | New public class containing extracted toast notification logic with auto-close timer functionality |
| src/DynamoCoreWpf/UI/GuidedTour/GuidesManager.cs | Removed toast notification methods and delegated to ToastManager |
| src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs | Added ToastManager property and updated all toast notification calls |
| src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs | Initialized ToastManager and added Python engine upgrade toast handler |
| src/DynamoCoreWpf/Views/GuidedTour/RealTimeInfoWindow.xaml.cs | Removed guided tour event subscriptions |
| test/DynamoCoreWpfTests/DynamoViewTests.cs | Updated test references and added new test for auto-close behavior |
| src/DynamoCoreWpf/PublicAPI.Unshipped.txt | Added public API entries for new ToastManager class |
| src/DynamoCoreWpf/DynamoCoreWpf.csproj | Added ToastManager.cs to project |
| (various other files) | Updated references from MainGuideManager to ToastManager for toast notifications |
…ynamoDS#16644) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ashish Aggarwal <ashish.aggarwal@autodesk.com>
Co-authored-by: Aaron (Qilong) <173288704@qq.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 110 out of 123 changed files in this pull request and generated no new comments.
Files not reviewed (4)
- src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
- src/Libraries/DSCPython/Properties/Resources.Designer.cs: Language not supported
- src/Libraries/PythonNodeModels/Properties/Resources.Designer.cs: Language not supported
- src/PythonMigrationViewExtension/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (2)
src/PythonMigrationViewExtension/PythonMigrationViewExtension.cs:1
- Corrected spelling of 'sis' to 'is a'.
src/PythonMigrationViewExtension/PythonMigrationViewExtension.cs:1 - Corrected spelling of 'toas' to 'toast'.
|
I think it looks good. There's a lot in there. |
They do need approval, but I took advantage of my access and merged it, because I wanted to test the merged build with all changes in 4.0, including the .Net10 final version, which was blocking other PRs from building successfully. All checks passed, and the PRs merged were already reviewed (cherry-picks) so seemed to be safe. |
Purpose
Cherry picks:
Declarations
Check these if you believe they are true
Release Notes
The complete PythonNet3 update to 4.0
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of