Skip to content

Conversation

@ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Nov 10, 2025

Purpose

This PR addresses DYN-9774.

It adds a DispatherTimer to ToastManager that automatically closes the toast popup after 3 seconds, if it hasn't been already closed by the user.

DYN-9774

Declarations

Check these if you believe they are true

Release Notes

All toast notification close automatically after 3 seconds.

Reviewers

@zeusongit
@DynamoDS/eidos

FYIs

@achintyabhat
@dnenov

Copilot AI review requested due to automatic review settings November 10, 2025 08:16
@github-actions github-actions bot changed the title DYN-9774: All toast notification should close after 3 sec 9828: DYN-9774: All toast notification should close after 3 sec Nov 10, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9828

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements automatic closing of toast notifications after 3 seconds to address DYN-9774. The change adds a DispatcherTimer that triggers the close action when the timeout expires, unless the user has manually closed the notification first.

Key Changes:

  • Added a DispatcherTimer to automatically close toast notifications after 3 seconds
  • Integrated timer lifecycle management (start/stop) with existing toast creation and closing logic

@ivaylo-matov ivaylo-matov changed the title 9828: DYN-9774: All toast notification should close after 3 sec DYN-9774: All toast notification should close after 3 sec Nov 10, 2025
@github-actions github-actions bot changed the title DYN-9774: All toast notification should close after 3 sec 9828: DYN-9774: All toast notification should close after 3 sec Nov 10, 2025
@zeusongit zeusongit added this to the 4.0 milestone Nov 11, 2025
@zeusongit zeusongit merged commit 46bb011 into DynamoDS:master Nov 11, 2025
24 of 27 checks passed
@github-actions
Copy link

Backport failed for RC4.0.0_master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin RC4.0.0_master
git worktree add -d .worktree/cherrypick-16683 origin/RC4.0.0_master
cd .worktree/cherrypick-16683
git switch --create cherrypick-16683
git cherry-pick -x 46bb011bc3e17c4979cea6af582f348cfb746bc6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants