-
Notifications
You must be signed in to change notification settings - Fork 668
9828: DYN-9774: All toast notification should close after 3 sec #16683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9828: DYN-9774: All toast notification should close after 3 sec #16683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements automatic closing of toast notifications after 3 seconds to address DYN-9774. The change adds a DispatcherTimer that triggers the close action when the timeout expires, unless the user has manually closed the notification first.
Key Changes:
- Added a
DispatcherTimerto automatically close toast notifications after 3 seconds - Integrated timer lifecycle management (start/stop) with existing toast creation and closing logic
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin RC4.0.0_master
git worktree add -d .worktree/cherrypick-16683 origin/RC4.0.0_master
cd .worktree/cherrypick-16683
git switch --create cherrypick-16683
git cherry-pick -x 46bb011bc3e17c4979cea6af582f348cfb746bc6 |
Purpose
This PR addresses DYN-9774.
It adds a
DispatherTimertoToastManagerthat automatically closes the toast popup after 3 seconds, if it hasn't been already closed by the user.Declarations
Check these if you believe they are true
Release Notes
All toast notification close automatically after 3 seconds.
Reviewers
@zeusongit
@DynamoDS/eidos
FYIs
@achintyabhat
@dnenov