DYN-9718: Add analytics to IsMLAutocompleteTOUApproved #16623
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9718
There was a problem hiding this comment.
Pull Request Overview
This PR adds analytics tracking to monitor user interactions with the autocomplete Terms of Use checkbox. When users check or uncheck the ML autocomplete agreement checkbox, an analytics event is now recorded.
Key Changes:
- Added analytics tracking call when
IsMLAutocompleteTOUApprovedproperty changes - Updated
DynamoVisualProgramming.Analyticspackage from version 4.2.2.10200 to 4.2.2.10255
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/DynamoCore/Configuration/PreferenceSettings.cs | Added analytics tracking call to record ML Terms of Use acceptance/rejection |
| src/DynamoCore/DynamoCore.csproj | Updated Analytics package version to support new tracking functionality |
| test/DynamoCoreTests/DynamoCoreTests.csproj | Updated Analytics package version in test project to match main project |
johnpierson
left a comment
There was a problem hiding this comment.
the analytics part lgtm, but lets remove the csproj changes.
(cherry picked from commit 3520a5f)
|
Successfully created backport PR for |
| isMLAutocompleteTOUApproved = value; | ||
| RaisePropertyChanged(nameof(IsMLAutocompleteTOUApproved)); | ||
|
|
||
| Analytics.TrackPreference("MLTermsOfUse", "", value ? 1 : 0); |
There was a problem hiding this comment.
This would mean that every time user adjusts the setting, this got reported.
This would not be equivalent to how many users actively enabling such TOU over the time. I think the latter is what we want to figure out, so I would suggest changes to this approach
Purpose
Add analytics to track when users check or uncheck the autocomplete checkbox
Declarations
Check these if you believe they are true
Release Notes
Add analytics to
IsMLAutocompleteTOUApprovedUpdate NuGet package reference of DynamoVisualProgramming.Analytics
Reviewers
@DynamoDS/synapse @DynamoDS/eidos
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of