DYN-8879: Check mark to graph properties menu item #16608
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8879
There was a problem hiding this comment.
Pull Request Overview
Adds a checkmark/toggle behavior for the File > Show Graph Properties > General menu item by binding it to the GraphMetadata extension menu item, mirroring previous Extensions menu behavior.
- Introduces BindGraphPropertiesMenu to bind and optionally toggle the extension-driven check state.
- Adds a field (graphMetadataHooked) to ensure event handlers are only attached once.
QilongTang
left a comment
There was a problem hiding this comment.
One comment then LGTM
|
This job seems to never complete after the last commit. The jira task is also marked for 4.1. |
@reddyashish Would you re-run the job? |
|
The last job also timed out and shows this "message":"This SHA and context has reached the maximum number of statuses.". The changes look straightforward and could be an issue with the this branch commits. @ivaylo-matov if you can open another PR with the same changes and close this, we can check the test job. |
|
Thanks Aaron, Merging this. The jira task is marked for 4.1 though. so not cherrypicking yet. |
|
@reddyashish @zeusongit Notice this is a follow up of #16476 so the earlier PR is already part of 4.0 release |
|
should be cherry-picked |
|
/cherrypick |
Co-authored-by: Aaron (Qilong) <173288704@qq.com> (cherry picked from commit e10e993)
|
Successfully created backport PR for |
Purpose
PR to address latest comments in DYN-8879.
Adds a checkmark to the File > Show Graph Properties > General menu item and allow clicking it to toggle the panel. This mirrors the behavior the item had when it lived under the Extensions menu.
The new BindGraphPropertiesMenu method subscribes using lambda event handlers. This should be fine here because the subscriber’s lifetime matches the DynamoView window lifetime.
Declarations
Check these if you believe they are true
Release Notes
Adds a checkmark to the File > Show Graph Properties > General menu item and allow clicking it to toggle the panel. This mirrors the behavior the item had when it lived under the Extensions menu.
Reviewers
@DynamoDS/eidos
FYIs
@dnenov
@achintyabhat