Skip to content

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Sep 25, 2025

Reverts #16508 to test CI errors

Copilot AI review requested due to automatic review settings September 25, 2025 15:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes that updated NuGet packages to target .NET 10.0, rolling back to .NET 8.0 targeting. The revert affects both the NuGet package specification and the project file configuration.

  • Reverts .NET target framework from net10.0 back to net8.0
  • Updates comments and build paths to reference .NET 8.0 instead of .NET 10.0
  • Maintains netstandard2.0 targeting alongside the reverted .NET 8.0 framework

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/NuGet/template-nuget/DynamoVisualProgramming.DynamoServices.nuspec Updates NuGet package specification to target .NET 8.0 and adjusts build paths and comments
src/NodeServices/DynamoServices.csproj Reverts target framework from net10.0 to net8.0 in project configuration

@QilongTang QilongTang requested a review from a team September 25, 2025 15:07
@QilongTang
Copy link
Contributor Author

Also triggered https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1496/ for regression checking

@zeusongit
Copy link
Contributor

If build images are updated with net10 sdk, won't this fail inherently?

@QilongTang QilongTang merged commit 45caa8e into master Sep 25, 2025
27 of 34 checks passed
@QilongTang QilongTang deleted the revert-16508-nuget-framework-net10 branch September 25, 2025 17:04
@dnenov dnenov mentioned this pull request Sep 25, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants