Skip to content

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Sep 22, 2025

Purpose

Migrate NuGet package configuration from .net8.0 to .net10.0. This ensures all generated NuGet packages will correctly target .net10.0 instead of .net8.0, maintaining consistency with the project's current .NET version alignment.

Declarations

Check these if you believe they are true

Release Notes

  • fixed DynamoServices.csproj and .nuspec to use net10.0 paths
  • updated build.xml DotNet property to set correct $TargetFramework$
  • ensures all NuGet packages target .NET 10.0 instead of .NET 8.0

Reviewers

@QilongTang
@Mikhinja

FYIs

@zeusongit

• fixed DynamoServices.csproj and .nuspec to use net10.0 paths
• updated build.xml DotNet property to set correct $TargetFramework$
• ensures all NuGet packages target .NET 10.0 instead of .NET 8.0
@dnenov dnenov requested a review from QilongTang September 22, 2025 16:39
@QilongTang QilongTang requested a review from Copilot September 22, 2025 16:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates NuGet package configuration from .NET 8.0 to .NET 10.0 to maintain consistency with the project's current target framework. The changes ensure that all generated NuGet packages will correctly target .NET 10.0 instead of .NET 8.0.

  • Updated target framework references from net8.0 to net10.0 across build configuration files
  • Modified NuGet package specification to include correct .NET 10.0 binaries and dependencies
  • Updated comments to reflect the new .NET 10.0 targeting

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tools/NuGet/template-nuget/DynamoVisualProgramming.DynamoServices.nuspec Updated NuGet package specification to target .NET 10.0 framework and reference correct binary paths
src/build.xml Changed DotNet property from net8.0 to net10.0 for build configuration
src/NodeServices/DynamoServices.csproj Updated target frameworks from net8.0 to net10.0 and corresponding comments

@zeusongit zeusongit requested a review from a team September 22, 2025 21:30
@dnenov dnenov changed the title Update NuGet packages to target .NET 10.0 DYN-9196 Update NuGet packages to target .NET 10.0 Sep 23, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9196

@QilongTang
Copy link
Contributor

@dnenov Please resolve the merge conflict of this PR

@dnenov
Copy link
Collaborator Author

dnenov commented Sep 25, 2025

@dnenov Please resolve the merge conflict of this PR

Yup, done now!

@QilongTang QilongTang merged commit ea01331 into DynamoDS:master Sep 25, 2025
24 of 28 checks passed
QilongTang added a commit that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants