-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-9196 Update NuGet packages to target .NET 10.0 #16508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
• fixed DynamoServices.csproj and .nuspec to use net10.0 paths • updated build.xml DotNet property to set correct $TargetFramework$ • ensures all NuGet packages target .NET 10.0 instead of .NET 8.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates NuGet package configuration from .NET 8.0 to .NET 10.0 to maintain consistency with the project's current target framework. The changes ensure that all generated NuGet packages will correctly target .NET 10.0 instead of .NET 8.0.
- Updated target framework references from net8.0 to net10.0 across build configuration files
- Modified NuGet package specification to include correct .NET 10.0 binaries and dependencies
- Updated comments to reflect the new .NET 10.0 targeting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/NuGet/template-nuget/DynamoVisualProgramming.DynamoServices.nuspec | Updated NuGet package specification to target .NET 10.0 framework and reference correct binary paths |
| src/build.xml | Changed DotNet property from net8.0 to net10.0 for build configuration |
| src/NodeServices/DynamoServices.csproj | Updated target frameworks from net8.0 to net10.0 and corresponding comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9196
|
@dnenov Please resolve the merge conflict of this PR |
Yup, done now! |
This reverts commit ea01331.
Purpose
Migrate NuGet package configuration from .net8.0 to .net10.0. This ensures all generated NuGet packages will correctly target .net10.0 instead of .net8.0, maintaining consistency with the project's current .NET version alignment.
Declarations
Check these if you believe they are true
Release Notes
Reviewers
@QilongTang
@Mikhinja
FYIs
@zeusongit