Skip to content

Conversation

@johnpierson
Copy link
Member

@johnpierson johnpierson commented Aug 28, 2025

Purpose

This PR fixes an issue with the ColorRange node by correcting the order of parameters when creating Color objects. The change ensures that the Alpha channel is properly included as the first parameter when calling the Color.ByARGB method.

Before:
image

After:
image

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Fixed a bug in the ColorRange node that caused incorrect parameter ordering when creating Color objects. The update ensures the Alpha channel is correctly passed first to the Color.ByARGB method.

Reviewers

@DynamoDS/eidos

FYIs

@achintyabhat @Amoursol @kronz @ivaylo-matov @jnealb

Copilot AI review requested due to automatic review settings August 28, 2025 20:28
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9457

This comment was marked as outdated.

@johnpierson johnpierson reopened this Aug 28, 2025
@johnpierson johnpierson changed the base branch from master to RC3.6.1_master August 28, 2025 20:30
@johnpierson johnpierson requested a review from Copilot August 28, 2025 20:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the ColorRange node by correcting the order of parameters when creating Color objects. The change ensures that the Alpha channel is properly included as the first parameter when calling the Color.ByARGB method.

Key Changes

  • Fixed parameter order in Color.ByARGB method call to include Alpha channel first

@johnpierson johnpierson requested a review from zeusongit August 28, 2025 20:31
@johnpierson johnpierson added this to the 3.6.1 milestone Aug 28, 2025
@zeusongit
Copy link
Contributor

Was there a similar fix made to master already?

@zeusongit zeusongit requested a review from a team September 3, 2025 14:21
@reddyashish
Copy link
Contributor

Not yet, will have to cherrypick into master.

Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reddyashish reddyashish merged commit 372f332 into DynamoDS:RC3.6.1_master Sep 3, 2025
22 of 24 checks passed
kalunkuo pushed a commit to kalunkuo/Dynamo that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants