-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-9457 - Color Range Fix #16481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-9457 - Color Range Fix #16481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9457
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with the ColorRange node by correcting the order of parameters when creating Color objects. The change ensures that the Alpha channel is properly included as the first parameter when calling the Color.ByARGB method.
Key Changes
- Fixed parameter order in Color.ByARGB method call to include Alpha channel first
|
Was there a similar fix made to master already? |
|
Not yet, will have to cherrypick into master. |
RobertGlobant20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
This PR fixes an issue with the ColorRange node by correcting the order of parameters when creating Color objects. The change ensures that the Alpha channel is properly included as the first parameter when calling the Color.ByARGB method.
Before:

After:

Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixed a bug in the ColorRange node that caused incorrect parameter ordering when creating Color objects. The update ensures the Alpha channel is correctly passed first to the Color.ByARGB method.
Reviewers
@DynamoDS/eidos
FYIs
@achintyabhat @Amoursol @kronz @ivaylo-matov @jnealb