DYN-9210: Prevent adding null nodes and transient nodes into groups #16406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9210
BogdanZavu
approved these changes
Jul 18, 2025
Contributor
|
LGTM! |
8 tasks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Under some order of operations, nodes with a null model are generating a null reference exception when dragged into groups. This PR prevents adding null nodes and transient nodes into groups.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Prevent adding null nodes and transient nodes into groups.
Reviewers
@DynamoDS/synapse
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of