DYN-8576 - change autocomplete popup to a Window to improve behavior #16208
Conversation
There was a problem hiding this comment.
Created a new constructor here, old one was already public and is currently marked as obsolete.
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8576
| HomeWorkspaceModel.WorkspaceClosed += this.CloseAutoCompletion; | ||
| } | ||
|
|
||
| public NodeAutoCompleteSearchControl(Window window, NodeAutoCompleteSearchViewModel viewModel) |
There was a problem hiding this comment.
Can this be internal ? I don't think we want it in the API.
|
Let's remove OnNodeAutoCompleteSearchControlVisibilityChanged Previously we were subscribing on visibility changed but did not unsubscribe on most closing contexts. |
| private void CurrentApplicationDeactivated(object sender, EventArgs e) | ||
| { | ||
| OnRequestShowNodeAutoCompleteSearch(ShowHideFlags.Hide); | ||
| OnRequestHideNodeAutoCompleteSearch(); |
There was a problem hiding this comment.
I think we don't want to hide the window on app deactivation anymore ; previously it was a popup and it was hiding by itself in many contexts.
Actually @chubakueno we can do this as part of another PR. So up to you. |
johnpierson
left a comment
There was a problem hiding this comment.
i agree with @BogdanZavu - lets try to get this merged and worry about the other comments in another pr. getting this existing dna node type match work implemented is valuable to move on to the next thing.
|
Improved the layout algorithm a bit so the window doesnt appear on different places depending on whether the AI sparkle is present to prepare to rebase onto 3.5.1 hotfix, feel free to merge when reviewed. |
Purpose
Change autocomplete Popup to a Window to improve control behavior. The main consequence of this is the control no longer being Topmost and not remaining on top of other programs or when Dynamo is minimized.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Revised existing Node AutoComplete Popup to window
Reviewers
@johnpierson
@BogdanZavu
FYIs
Change autocomplete Popup to a Window to improve control behavior.