[DYN-8560] Chart nodes: Resize handle and Preview icon overlap #16142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8560
Contributor
|
PressNotificationButtonAndShowPopup is failing. Can you verify that locally? |
Contributor
Author
|
@reddyashish, the test passes here
|
Contributor
reddyashish
approved these changes
Apr 23, 2025
Contributor
|
/cherrypick |
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2025
(cherry picked from commit 385626e)
9 tasks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses DYN-8560, which reported an issue where the resize thumb and the preview icon overlap, making the thumb difficult or impossible to use.
To resolve this, I’ve applied the same approach used in Curve Mapper to all chart nodes by setting their IsResizable property to true. This adjustment shifts the glyph icon to the left, creating room for the resize thumb.
I’ve also updated the cursor appearance when hovering over the resize thumb to match the behavior seen in Curve Mapper.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Chart nodes are now resizable, with improved cursor behavior and layout adjustments to prevent overlap between the resize thumb and preview icon.
Reviewers
@reddyashish
@zeusongit
FYIs
@dnenov
@achintyabhat