DYN-8268: fix noNetworkMode for PM client #15809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8268
UI Smoke TestsTest: success. 11 passed, 0 failed. |
mjkkirschner
approved these changes
Feb 5, 2025
QilongTang
reviewed
Feb 5, 2025
| /// Method to load the map once, making it accessible to all elements | ||
| /// </summary> | ||
| private void LoadCompatibilityMap() | ||
| internal void LoadCompatibilityMap() |
Contributor
There was a problem hiding this comment.
So the call of CompatibilityMap() is the one causing network traffic?
Member
|
would be really nice @zeusongit if we could implement some tests to catch this regression from occurring each year. I think there is a task for it. |
Contributor
Makes sense, I will look for the task, but please share if you find it as well. |
zeusongit
pushed a commit
to zeusongit/Dynamo
that referenced
this pull request
Feb 7, 2025
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop calling pm KnownHosts while under NoNetworkMode
Purpose
https://jira.autodesk.com/browse/DYN-8268
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of