Skip to content

DYN-7720. Add Help file documentation for Mesh Nodes from Meshtoolkit #15588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saintentropy merged 5 commits into from
Nov 4, 2024
Merged

DYN-7720. Add Help file documentation for Mesh Nodes from Meshtoolkit #15588

saintentropy merged 5 commits into from
Nov 4, 2024

Conversation

@saintentropy
Copy link
Contributor

@saintentropy saintentropy commented Nov 2, 2024 •
edited
Loading

Purpose

Documentation files are included for the new Mesh Nodes.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Documentation files are included for the new Mesh Nodes.

Reviewers

@LongNguyenP

FYIs

@Amoursol

github-actions[bot]
github-actions bot reviewed Nov 2, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7720

@github-actions
Copy link

github-actions bot commented Nov 2, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang added this to the 3.4 milestone Nov 4, 2024
@QilongTang
Copy link
Contributor

QilongTang commented Nov 4, 2024

My only concern is about all these geometry nodes' name lengths. I think sometime ago, @sm6srw had to convert long named files to be in hashed value. I forgot if C3D team or Revit team documented a limitation somewhere but I would encourage us using hashed value when we can.

@saintentropy
Copy link
Contributor Author

saintentropy commented Nov 4, 2024

@QilongTang not sure what the limit is... Currently the longest Mesh file Autodesk.DesignScript.Geometry.Mesh.Translate(mesh.vector.distance)_img.jpg is shorter then other geometry help files like Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BySphereBestFit_img.jpg and Autodesk.DesignScript.Geometry.PanelSurface.ByCustomOrthogonalLattice_img.jpg.

LongNguyenP
LongNguyenP approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@LongNguyenP LongNguyenP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saintentropy
Copy link
Contributor Author

saintentropy commented Nov 4, 2024

@QilongTang I can't find the number yet that we convert files to hashed values. Since we are not longer then others I will merge and add this for follow up

@saintentropy saintentropy merged commit 5094d85 into DynamoDS:master Nov 4, 2024
saintentropy added a commit to saintentropy/Dynamo that referenced this pull request Nov 4, 2024
@saintentropy
DYN-7720. Add Help file documentation for Mesh Nodes from Meshtoolkit (…
c8d8b18 
…DynamoDS#15588)

(cherry picked from commit 5094d85)
@saintentropy saintentropy mentioned this pull request Nov 4, 2024
Merged
9 tasks
@johnpierson
Copy link
Member

johnpierson commented Mar 5, 2025 •
edited
Loading

Currently the longest Mesh file Autodesk.DesignScript.Geometry.Mesh.Translate(mesh.vector.distance)_img.jpg is shorter then other geometry help files like Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BySphereBestFit_img.jpg and Autodesk.DesignScript.Geometry.PanelSurface.ByCustomOrthogonalLattice_img.jpg.

@saintentropy @QilongTang

I wanted to add to this that right now we are building automations for checking these files and they currently need to follow naming of the DYN. So the . in the parentheses in these examples is causing a few issues at this time.

Autodesk.DesignScript.Geometry.Mesh.Translate(mesh.vector.distance)_img.jpg should read as ``Autodesk.DesignScript.Geometry.Mesh.Translate(mesh, vector, distance)_img.jpg`.

But if we were to use hashed values, we need to account for that in our automation as well. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@LongNguyenP LongNguyenP LongNguyenP approved these changes

@QilongTang QilongTang Awaiting requested review from QilongTang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@saintentropy @QilongTang @johnpierson @LongNguyenP