Skip to content

update Dynamo Home version #15247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
May 28, 2024
Merged

update Dynamo Home version #15247

QilongTang merged 1 commit into from
May 28, 2024

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented May 24, 2024 •
edited
Loading

Purpose

Update Dynamo version to include more localized resources - backup locations

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Update Dynamo version to include more localized resources - backup locations

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.2 milestone May 24, 2024
@github-actions
Copy link

github-actions bot commented May 24, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang
Copy link
Contributor Author

QilongTang commented May 24, 2024

Previous self serve job failed at build time, restarting in https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16092/

@QilongTang
Copy link
Contributor Author

QilongTang commented May 24, 2024 •
edited
Loading

I would not expect regression in Dynamo.Tests.SerializationTests.SerializationInDifferentCultureTest("C:\Jenkins\workspace\Dynamo\DynamoSelfServe\pullRequestValidation\Dynamo\test\core\astbuilder\updateInputNodeModel.dyn"), running it again

All of them pass locally

@QilongTang
Copy link
Contributor Author

QilongTang commented May 28, 2024

Passed in https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16093/

@QilongTang QilongTang merged commit 2624204 into master May 28, 2024
@QilongTang QilongTang deleted the UpdateHome branch May 28, 2024 14:17
QilongTang added a commit that referenced this pull request May 28, 2024
@QilongTang
update Dynamo Home version (#15247)
74aa9da
@QilongTang QilongTang mentioned this pull request May 28, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request May 28, 2024
@QilongTang
[Cherry pick] #15247 More localization on Dynamo Home (#15258)
6966d47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avidit avidit avidit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @avidit