Skip to content

DYN-6990 Crash when selecting node with view extension #15231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeusongit merged 1 commit into from
May 20, 2024
Merged

DYN-6990 Crash when selecting node with view extension #15231

zeusongit merged 1 commit into from
May 20, 2024

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented May 20, 2024 •
edited
Loading

Purpose

This PR handles the crash described in https://jira.autodesk.com/browse/DYN-6990,
the crash seems to occur when the user tried make a selection of node(s), the main issue could be related an action performed with monocle extension. I was not able to re-produce the crash in Dynamo 3.0.3, the version of monocle used is not provided but I tried with 2024.5.1.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fix crash when selecting node with view extension

Reviewers

@DynamoDS/dynamo

github-actions[bot]
github-actions bot reviewed May 20, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6990

@github-actions
Copy link

github-actions bot commented May 20, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.2 milestone May 20, 2024
@QilongTang
Copy link
Contributor

QilongTang commented May 20, 2024

One regression? DynamoCoreWpfTests.DynamoViewTests.OpeningWorkspaceWithTclsrustWarning

@zeusongit
Copy link
Contributor Author

zeusongit commented May 20, 2024

One regression? DynamoCoreWpfTests.DynamoViewTests.OpeningWorkspaceWithTclsrustWarning

Saw that, it is passing locally, so I have triggered a rebuild

@zeusongit
Copy link
Contributor Author

zeusongit commented May 20, 2024

Build passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16051/, the one test failing before probably was a fluke, merging.

@zeusongit zeusongit merged commit fa05e22 into DynamoDS:master May 20, 2024
Enzo707 pushed a commit to Enzo707/Dynamo that referenced this pull request May 22, 2024
@zeusongit @EnzoBatistaU
DYN-6990 Crash when selecting node with view extension (DynamoDS#15231)
5726921
@johnpierson
Copy link
Member

johnpierson commented Feb 11, 2025

I wanted to add a comment here just to have it documented.

The users that are reporting errors are using a very old version of monocle (v.2022.2.1) in Dynamo 3.2.2. That version of monocle was .Net Framework 4.8 (pre .net8). So it is having crashes when not finding DLLs.

I am thankful this is fixed already, but, the users were using an incorrect version ultimately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@zeusongit @QilongTang @johnpierson