DYN-6769 Improving Dynamo Load Graph II #15108
Conversation
With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore.
With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore.
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
Hi @RobertGlobant20 LGTM, can you demonstrate the performance improvement also as part of this PR? |
I'm still trying to get the performance improvement numbers, basically the problem is that improvement is in the range of seconds but when I run dotTrace and Dynamo opening a dyn file, the loading time has a lot of variation (between each sample) so is hard to show the performance improvement. |
Maybe use the timer to time the time spent on searching on each of the predefined keyword in the query, we are saving that much of time with each workspace open |
I've used a StopWatch timer to get the time consumed when executing the Search for DefaultNodeAutocompleteCandidates, as you can see with my fix we are saving around 5 seconds due that the Search is executed only once (when Dynamo opens is executed two times and when a graph is opened is executed another two times). |
|
@RobertGlobant20 Please also cherry-pick this |
* DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore. * DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore.
* DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore. * DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore.
This reverts commit 30e7c0d.
* DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore. * DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore.
* DYN-6769 Improving Dynamo Load Graph II (#15108) * DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore. * DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore. * DYN-6769 Improving Dynamo Load Graph II - 2 Instead of using a static Dictionary now I will be using a normal instance that will be initialized in DynamoViewModel and pass it to NodeAutoCompleteSearchViewModel, in this case we are also confirming that only be executed once. * DYN-6769 Improving Dynamo Load Graph II - 2 Disabling the DefaultNodeAutocomplete functionality when Dynamo is in ServiceMode. * DYN-6769 Improving Dynamo Load Graph II Marking the test RemovePIIDataFromWorkspace as Failure
Purpose
With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup, then when a graph is loaded won't be executed.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup, then when a graph is loaded won't be executed.
Reviewers
@QilongTang
FYIs