Skip to content

Remove ASM229 #14952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sm6srw merged 1 commit into from
Feb 16, 2024
Merged

Remove ASM229 #14952

sm6srw merged 1 commit into from
Feb 16, 2024

Conversation

@sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Feb 16, 2024 •
edited
Loading

Purpose

Remove support for ASM229.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Removed support for ASM229.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@sm6srw sm6srw added the WIP label Feb 16, 2024
@github-actions
Copy link

github-actions bot commented Feb 16, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@sm6srw sm6srw removed the WIP label Feb 16, 2024
@sm6srw
Copy link
Contributor Author

sm6srw commented Feb 16, 2024

Passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/14733/ with one sporadic failure.

@sm6srw sm6srw merged commit 1eb5463 into DynamoDS:master Feb 16, 2024
@sm6srw sm6srw deleted the DYN-6664 branch February 16, 2024 19:53
sm6srw added a commit to sm6srw/Dynamo that referenced this pull request Feb 16, 2024
@sm6srw
Remove ASM229 (DynamoDS#14952)
fb034bb
sm6srw added a commit that referenced this pull request Feb 20, 2024
@sm6srw
Cherry pick DYN-6664 (#14954)
d98b2d9 
* Remove ASM229 (#14952)

* Only copy LibG for ASM230
@sm6srw sm6srw modified the milestones: 3.1, 3.0.4 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aparajit-pratap aparajit-pratap aparajit-pratap approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.4

Development

Successfully merging this pull request may close these issues.

2 participants

@sm6srw @aparajit-pratap