Skip to content

Updates to Node AutoComplete ML TOU UX #14825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 3 commits into from
Jan 11, 2024
Merged

Updates to Node AutoComplete ML TOU UX #14825

QilongTang merged 3 commits into from
Jan 11, 2024

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jan 10, 2024 •
edited
Loading

Purpose

Updates to Node AutoComplete ML TOU UX:

  • Change Agreement and Terms of Use menu item to Agreements for Data Collection

image

  • Change I would like to participate in data collection checkbox to I would like to participate in data collection for Machine Learning Programs

After:
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Change Agreement and Terms of Use to Agreements to Data Collection
Change I would like to participate in data collection to I would like to participate in data collection for Machine Learning Programs

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.0.2 milestone Jan 10, 2024
@github-actions
Copy link

github-actions bot commented Jan 10, 2024

UI Smoke Tests

Test: failure. 1 passed, 1 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Jan 10, 2024

UI Smoke Tests

Test: failure. 1 passed, 1 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Jan 10, 2024

UI Smoke Tests

Test: failure. 1 passed, 1 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@zeusongit
Copy link
Contributor

zeusongit commented Jan 10, 2024

1 test failure

@QilongTang
Copy link
Contributor Author

QilongTang commented Jan 10, 2024 •
edited
Loading

1 test failure

I guess since we touch the dialog title, we need to update the smoke test. FYI: @avidit

@QilongTang QilongTang merged commit 19f0967 into master Jan 11, 2024
@QilongTang QilongTang deleted the TOUupdates branch January 11, 2024 06:11
QilongTang added a commit that referenced this pull request Jan 11, 2024
@QilongTang
Updates to Node AutoComplete ML TOU UX (#14825)
78542ce 
* updates

* update

* Remove tooltip for menu item
@QilongTang QilongTang mentioned this pull request Jan 11, 2024
Merged
9 tasks
QilongTang added a commit that referenced this pull request Jan 11, 2024
@QilongTang
Updates to Node AutoComplete ML TOU UX (#14825) (#14831)
971e0d6 
* updates

* update

* Remove tooltip for menu item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeusongit zeusongit zeusongit approved these changes

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @zeusongit