Skip to content

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Dec 8, 2023

Purpose

Fixes an issue where the Known Host filters will remain selected in-between form resets in the Publish Package tab.

Fix

reset known filters

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • now resets selected known hosts between publish package usages/resets

Reviewers

@reddyashish
@avidit

FYIs

@QilongTang

- now resets selected known hosts between publish package usages/resets
@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions
Copy link

github-actions bot commented Dec 8, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@reddyashish
Copy link
Contributor

Passed: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1344/. Will cherrypick this into 3.0

@reddyashish reddyashish merged commit f5fddc3 into DynamoDS:master Dec 12, 2023
reddyashish pushed a commit to reddyashish/Dynamo that referenced this pull request Dec 14, 2023
- now resets selected known hosts between publish package usages/resets

(cherry picked from commit f5fddc3)
QilongTang pushed a commit that referenced this pull request Dec 14, 2023
* remove duplicate dyf file warning from preview generation process (#14711)

- dynamo would issue a warning and fail to publish a package if an 'unqualified' file is being used, such as a dyf file already under package control
- this check is done when publishing package locally, but I have incorrectly added it to the process of creating a build preview, which stops the process for both local and online submit workflow

(cherry picked from commit 3ea1c5c)

* remove package version limitation (#14716)

- now allows package version to start with 0
- cannot have 0.0.0 package version

(cherry picked from commit 992e54c)

* reinstate description check (#14717)

- brought back description check as publish online API still requires it

(cherry picked from commit d70c7b5)

* name validation fix, page navigate fix (#14724)

- fine-tune name validation and warning display
- also fixes issue when navigating away from the publish page and setting up the datacontext of the PackageManagerPublishControl

(cherry picked from commit 57f5883)

* reset selected known hosts (#14722)

- now resets selected known hosts between publish package usages/resets

(cherry picked from commit f5fddc3)

---------

Co-authored-by: Deyan Nenov <dnenov@archilizer.com>
@dnenov dnenov mentioned this pull request Dec 14, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants