-
Notifications
You must be signed in to change notification settings - Fork 668
TSpline Nodes Documentation - Third set #14598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 26 commits into
DynamoDS:master
from
dariaivanciucova:TSpline-nodes-documentation-third-set
Feb 1, 2024
Merged
TSpline Nodes Documentation - Third set #14598
QilongTang
merged 26 commits into
DynamoDS:master
from
dariaivanciucova:TSpline-nodes-documentation-third-set
Feb 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Vertices, NGonFaces, NonManifoldEdges, NonManifoldVertices
|
✅ Bin Diff Issue Resolved. |
…dCoincidentVertices, WeldVertices(2)
…b.com/dariaivanciucova/Dynamo into TSpline-nodes-documentation-third-set
hwahlstrom
reviewed
Nov 20, 2023
Collaborator
hwahlstrom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor fixes
...istrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.DuplicateFaces.md
Outdated
Show resolved
Hide resolved
...istrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.DuplicateFaces.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.Interpolate.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.IsClosed.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.IsClosed.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/UVMMX2H7AW6KY7XACJHBCRTDYLOGHPZHWREHFNQUMZ6SK33XMHHQ_img.jpg
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/WO4HBR4YYKPQOTXPPFJWGC6B66KH4HDONFO6W7XXS7TACWL7P6YA_img.jpg
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/XGSWLBVZ2TGT6X7FZRUWJDGDSBL7JWKDBQYWEJWO7VZOJPJI7OWQ.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/XGSWLBVZ2TGT6X7FZRUWJDGDSBL7JWKDBQYWEJWO7VZOJPJI7OWQ.md
Outdated
Show resolved
Hide resolved
doc/distrib/NodeHelpFiles/ZBLSFRQNVI3VPC3KTS3XZI6VXSAJAON2ETVE46OLR7NMYOY6INXA.md
Outdated
Show resolved
Hide resolved
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
approved these changes
Feb 1, 2024
QilongTang
pushed a commit
that referenced
this pull request
Feb 6, 2024
* DYN-6535 DynamoRevit Improve Search Fix 2 The specific case "element set parameter" was failing on Revit 2025 (not finding anything), then I've modified the code so that check if the first term is a category if that is the case it will create a specific query using the first term as category and the next terms as node name. * DYN-6535 DynamoRevit Improve Search Fix 2 Code Review Updating Linq query so that is executed only once. * Squashed commit of the following: commit 3893c85 Author: Ashish Aggarwal <ashish.aggarwal@autodesk.com> Date: Mon Feb 5 12:53:49 2024 -0500 Fix retain package structure flow where nested directory at root level were lost (#14918) * optimize * comments and a test * add subdir test and comments * add child test * test updates commit d0bd96e Author: Aaron (Qilong) <173288704@qq.com> Date: Fri Feb 2 15:56:03 2024 -0500 Fix API breaking changes (#14916) * Fix API breaking changes * Update OpenFileCommand * update commit 8f123fe Author: Daria Ivanciucova <43077096+dariaivanciucova@users.noreply.github.com> Date: Fri Feb 2 03:20:48 2024 +0000 TSpline rename hashed nodes (#14921) * renamed 2 nodes TSplineSurface.BySphereCenterPointRadius TSplineSurface.ByCylinderPointsRadiu * TSplineSurface.ByPlaneOriginNormal * TSplineSurface.ByQuadballCenterRadius * TSplineSurface.BySphereFourPoints * TSplineSurface.ByPlaneOriginNormalXAxis * TSplineSurface.ByPlaneOriginXAxisYAxis * TSplineVertex.FunctionalValence * TSplineSurface.ByConeCoordinateSystemHeightRadii * TSplineSurface.ByPlaneBestFitThroughPoints * TSplineSurface.ByPlaneLineAndPoint * TSplineSurface.ByPlaneThreePoints * TSplineSurface.ByTorusCenterRadii * TSplineSurface.ByTorusCoordinateSystemRadii * TSplineTopology.TPointVertices * TSplineSurface.AddReflections * TSplineSurface.DeleteVertices * TSplineSurface.CompressIndices * TSplineSurface.RemoveReflections * TSplineSurface.ByNurbsSurfaceUniform * TSplineSurface.UnweldVertices * TSplineSurface.BridgeFacesToEdges * TSplineReflection.SegmentsCount * TSplineSurface.ByNurbsSurfaceCurvature * TSplineSurface.BridgeEdgesToFaces * TSplineInitialSymmetry.IsRadial; TSplineInitialSymmetry.RadialSymmetryFaces * TSplineReflection.SegmentsAngle * .TSplineSurface.BridgeFacesToFaces * TSplineSurface.BridgeEdgesToEdges * TSplineInitialSymmetry.ByRadial * SplineSurface.ByCombinedTSplineSurfaces * TSplineSurface.UncreaseVertices * BuildFromLines * TSplineSurface.CreaseVertice * TSplineTopology.RegularVertices * TSplineTopology.VertexByIndex * TSplineSurface.DeserializeFromTSM * TSplineSurface.SerializeAsTSM * TSplineTopology.BorderVertices * TSplineSurface.EnableSmoothMode * TSplineTopology.NonManifoldVertices * TSplineTopology.VerticesCoun * TSplineSurface.DuplicateFaces * TSplineSurface.ExtrudeEdgesAlongCurve * TSplineTopology.StarPointVertices * TSplineTopology.NonManifoldEdges * TSplineSurface.WeldCoincidentVertices * TSplineSurface.SubdivideFaces * TSplineSurface.ExtrudeFacesAlongCurve * TSplineSurface.ByConeCoordinateSystemHeightRadius * TSplineSurface.ByCylinderRadiusHeight commit 2bb51dc Author: Daria Ivanciucova <43077096+dariaivanciucova@users.noreply.github.com> Date: Thu Feb 1 17:43:53 2024 +0000 TSpline Nodes Documentation - Third set (#14598) * FillHole, IsClosed, IsInBoxMode * BorderFaces, BorderEdges, BorderVertices, DuplicateFaces * EnableSmoothMode, ExportToTSS, ExportToTSM * ImportFromTSM (2) * ImportFromTSS(2) * ExtrudeFaces, Interpolate, SubdivideFaces, FlattenVertices (2) * IsStandard, Standardize, Thicken (2) * Decomposed (3), EdgeByIndex, EdgeCount, InnerEdges, InnerFaces, InnerVertices, NGonFaces, NonManifoldEdges, NonManifoldVertices * RegularFaces, RegularVertices, StarPoints, TPoints * Repair, Serialize, Deserialize * ExtrudeEdges, ExtrudeEdgesAlongCurve, ExtrudeFacesAlongCurve * FlipNormals, IsExtractable * MoveVertices, FaceByIndex, VertexByIndex * Is Watertight, FacesCount, VerticesCount, SlideEdges, MergeEdges, WeldCoincidentVertices, WeldVertices(2) * ToBrep, ToMesh * Update WSNXB54TDQEZRTUNRFCTUDK74DHVPQPXBXEYJUZJPW6T2F7XERDQ.md * CreateMatch (2), PullVertices * MakeUniform * updated to better method for highlighting edges * spell check * Update 6ICXLN4V6DNK5KMYTY5LPCJBE27IRW5VOBKCCVFQGO3HST752ZNQ.md * added TSM, TSS files, typos * Helena's comments --------- Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> commit 9136633 Author: Daria Ivanciucova <43077096+dariaivanciucova@users.noreply.github.com> Date: Thu Feb 1 16:59:41 2024 +0000 TSpline Nodes Documentation - Second set (#14550) * TSplineInitialSymmetry nodes * TSplineReflection nodes documentation * two more Reflections nodes * 7 more nodes - Bevel Edges - Crease Edges - Crease Vertices - Uncrease Edges - Uncrease Vertices - Unweld Edges - Unweld Vertices * ByNurbs and ByCombinedSurfaces - ByNurbsSurfaceCurvature -ByNurbsSurfaceUniform - ByCombinedTSplineSurfaces * 4 Bridge nodes * Compress Indexes, BySweep, ByRevolve, BuildFromLines * DeleteEdges, DeleteFaces, DeleteVertices * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeEdgesToEdges.md * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeEdgesToFaces.md * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeFacesToEdges.md * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeFacesToFaces.md * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BuildFromLines.md * added missing TSplineSurface.Reflections node * Helena's comments --------- Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> commit 99cf281 Author: Deyan Nenov <dnenov@archilizer.com> Date: Thu Feb 1 16:58:27 2024 +0000 binding issues resolved (#14682) - fixed null exception when trying to assign click handler on a context menu button when the parent button - also fixed another incorrect binding issue commit d2e57b5 Author: Daria Ivanciucova <43077096+dariaivanciucova@users.noreply.github.com> Date: Thu Feb 1 15:58:29 2024 +0000 TSpline Nodes Documentation - First set (#14549) * TSEdge and TSFace nodes documentation * TSpline Vertex nodes documentation * TSpline.UVNFrame nodes documentation * Update Autodesk.DesignScript.Geometry.TSpline.TSplineVertex.IsStarPoint.md * TSpline Box docs * TSplineSurface.ByPlane nodes docs * TSplineSurface.ByCone docs * TSplineSurface - Cylinder docs * TSplineSurface.ByQuadball nodes * replaced with renamed files for ByBox nodes * BySphere nodes * TSplineSurface.ByTorus nodes * BuildPipes and ByExtrude * Update Autodesk.DesignScript.Geometry.TSpline.TSplineVertex.Index.md * corrected the description for Torus nodes * Helena's comments --------- Co-authored-by: Deyan Nenov <dnenov@archilizer.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> * Revert "Squashed commit of the following:" This reverts commit c182c1b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A third batch of documentation help files for T-Spline nodes.
The In-Depth description follows this guidance.
This batch includes In-Depth, Example image, and .dyn files for the following 63 nodes:
Topology
T-Spline Surface
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Renamed nodes are submitted with their short names.
For the
TSplineSurface.SubdivideFacesthe short definition is wrong:Subdivide given faces into four faces each in exact or simple mode depending on given flag value.
For NGon faces the subdivision has a different number of faces (can be 3 or n).
For the
TSplineSurface.CreateMatch(tSplineSurface, tsEdges, curves)the tooltip forcurvesis wrong:Closed curve loop to create match with
The curve does not have to be a closed loop.
For
TSplineSurface.CreateMatch(tSplineSurface, tsEdges, brepEdges)thecontinuitydoes not currently support G1 & G2 continuity.Reviewers
FYIs
@dnenov @Amoursol