2.19.1 disable network traffic #14393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
This reverts commit 6f9761d.
* disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
* Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
|
|
sm6srw
reviewed
Sep 8, 2023
QilongTang
approved these changes
Sep 11, 2023
Contributor
|
@mjkkirschner All changes looks good, this is no longer WIP right? |
Member
Author
|
@QilongTang let me make a few last updates to this! |
Member
Author
|
@QilongTang @sm6srw PTAL - I added some TODO comments and also disabled the notifications center if the DisableAnalytics static props was set true. I think this should be safe to merge to master as well so we can stop doing these one off builds in the future. |
Contributor
Thanks, nicely done |
Member
Author
|
@QilongTang I was hoping we'd wait for the tests to pass 😬 - I will keep an eye on them. |
Contributor
|
@mjkkirschner The previous job does have tests passed and given we have no tests for notification center, I merged. I will have another PR to update release version etc |
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Sep 11, 2023
* cherry pick analytics issue (DynamoDS#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Revert "cherry pick analytics issue (DynamoDS#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (DynamoDS#13328) (DynamoDS#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Disable net traffic (DynamoDS#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Update PreferencesViewModel.cs: crash due to null feature flags (DynamoDS#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
mjkkirschner
added a commit
that referenced
this pull request
Sep 11, 2023
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> --------- Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
mjkkirschner
added a commit
that referenced
this pull request
Sep 19, 2023
* fix most memory leaks from opening and closing Dynamo Splash Screen (#14344) * fixing mem leaks in progress * fix test and remove todo * 2.19.1 disable network traffic WIP (#14393) * cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * add python tests * move project * revert --------- Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
pinzart90
added a commit
that referenced
this pull request
Oct 28, 2023
* cherry pick analytics issue (#13328) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Revert "cherry pick analytics issue (#13328)" This reverts commit 6f9761d. * cherry pick analytics issue (#13328) (#14085) * update * update * null checking * update * Update CoreNodeModelWpfResources.Designer.cs Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Disable net traffic (#14083) * disable net traffic example * Update PackageManagerViewExtension.cs * update * Update DynamoModel.cs * Update PackageManagerViewExtension.cs * Update PackageManagerViewExtension.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * Update PreferencesViewModel.cs: crash due to null feature flags (#14087) * Update PreferencesViewModel.cs * Update PackageManagerViewExtensionTests.cs --------- Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com> * changes * remove comment * comments and disable notifications --------- Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com> Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in some changes from @pinzart90's changes for 2.17.4 and tries to adapt them to use the
DisableAnalyticsflag as a stand inDisableNetworkActivityflag until we have that.Additionally, it disables the notification center requests if
DisableAnalyticsis true.I believe it is safe to merge to master, unlike the original changes.