Skip to content

Dyn 5816 - Set the PathManager class as internal #14263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 7 commits into from
Aug 15, 2023
Merged

Dyn 5816 - Set the PathManager class as internal #14263

QilongTang merged 7 commits into from
Aug 15, 2023

Conversation

@jesusalvino
Copy link
Contributor

@jesusalvino jesusalvino commented Aug 15, 2023

Purpose

Reduce the scope to the .Core namespace

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@QilongTang
@pinzart90
@mjkkirschner

@jesusalvino jesusalvino mentioned this pull request Aug 15, 2023
Merged
9 tasks
@mjkkirschner
Copy link
Member

mjkkirschner commented Aug 15, 2023

this should also be cherry picked to 2.19 I think.

@QilongTang QilongTang added this to the 2.19.0 milestone Aug 15, 2023
@QilongTang QilongTang merged commit b84aea7 into DynamoDS:master Aug 15, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Aug 15, 2023

this should also be cherry picked to 2.19 I think.

Agreed

@jesusalvino
Copy link
Contributor Author

jesusalvino commented Aug 15, 2023

this should also be cherry picked to 2.19 I think.

Agreed

Done #14265

QilongTang pushed a commit that referenced this pull request Aug 15, 2023
@jesusalvino
Dyn 5816 - Set the PathManager class as internal (#14263) (#14265)
42d134d 
* Rollback fron the 6213 commit

* Rollback the cc58

* Reducing scope

---------

Co-authored-by: Jesus Alfredo Alviño <jesus.alfredo.alvino@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.19.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jesusalvino @mjkkirschner @QilongTang