Introducing a global Lucene search singleton class #14248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertGlobant20
requested changes
Aug 10, 2023
Contributor
RobertGlobant20
left a comment
There was a problem hiding this comment.
LGTM with 2 comments and one minor refactoring change.
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Outdated
Show resolved
Hide resolved
9 tasks
QilongTang
reviewed
Aug 14, 2023
QilongTang
reviewed
Aug 14, 2023
Contributor
|
@QilongTang @reddyashish |
Contributor
|
@RobertGlobant20 Addressed the merge conflict |
Contributor
|
@RobertGlobant20 Fixed the fork, waiting for PR checks |
QilongTang
reviewed
Aug 23, 2023
| { | ||
| get | ||
| { | ||
| return LuceneSearch.LuceneUtilityNodeSearch; |
Contributor
There was a problem hiding this comment.
@RobertGlobant20 @reddyashish Fixed a regression with a one line change here, see 2d2226e. Moving forward, we should leverage singleton instead of relying on DynamoModel. I will watch for PR check results
Contributor
9 tasks
QilongTang
added a commit
that referenced
this pull request
Aug 23, 2023
* Lucene search singleton class. * Update LuceneSearch.cs * Updates * updates * Update LuceneSearch.cs * Update * Update * Fix regressions --------- Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: Aaron (Qilong) <aaron.tang@autodesk.com>
9 tasks
QilongTang
added a commit
that referenced
this pull request
Aug 23, 2023
* Lucene search singleton class. * Update LuceneSearch.cs * Updates * updates * Update LuceneSearch.cs * Update * Update * Fix regressions --------- Co-authored-by: reddyashish <43763136+reddyashish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a LuceneSearch singleton class that will have access to the 3 LuceneSearchUtilities used in Dynamo.
This should be merged after #14214. Once it is merged, this PR will have some conflicts.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@QilongTang @RobertGlobant20
FYIs
@DynamoDS/dynamo