DYN-5732-PythonNodes-HelpDoc #13923
Merged
DYN-5732-PythonNodes-HelpDoc #13923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the next bugs for the PythonScript and PythonScriptFromString: The preview graph images in DocumentationBrowser are not updated using the latest modern style. When trying to insert the Documentation graph into the workspace is sending an error due that the dyn file doesn't exist. Then I did the next fixes: - The missing dyn files were added to Dynamo\doc\distrib\NodeHelpFiles folder. - The dyn files were updated in Dynamo and got screenshots for replacing the jpg images in Dynamo\doc\distrib\NodeHelpFiles.
Contributor
Author
|
GIF showing behavior for PythonScript node. |
reddyashish
approved these changes
Apr 21, 2023
Contributor
Author
|
GIF showing behavior for the PythonScriptFromString. |
Contributor
|
@RobertGlobant20 Can you cherry-pick this to RC2.18.0_master branch? |
9 tasks
reddyashish
pushed a commit
that referenced
this pull request
Apr 24, 2023
Fixing the next bugs for the PythonScript and PythonScriptFromString: The preview graph images in DocumentationBrowser are not updated using the latest modern style. When trying to insert the Documentation graph into the workspace is sending an error due that the dyn file doesn't exist. Then I did the next fixes: - The missing dyn files were added to Dynamo\doc\distrib\NodeHelpFiles folder. - The dyn files were updated in Dynamo and got screenshots for replacing the jpg images in Dynamo\doc\distrib\NodeHelpFiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replacing preview images and dyn files for PythonScript and PythonScriptFromString nodes.
Fixing the next bugs for the PythonScript and PythonScriptFromString: The preview graph images in DocumentationBrowser are not updated using the latest modern style. When trying to insert the Documentation graph into the workspace is sending an error due that the dyn file doesn't exist.
Missing validation for jpg images resolution
Then I did the next fixes:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Replacing preview images and dyn files for PythonScript and PythonScriptFromString nodes.
Reviewers
@QilongTang @reddyashish @Amoursol
FYIs