Skip to content

Move the SciPy package out into its own resource file #13795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sm6srw merged 1 commit into from
Mar 3, 2023
Merged

Move the SciPy package out into its own resource file #13795

sm6srw merged 1 commit into from
Mar 3, 2023

Conversation

@sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Mar 2, 2023

Purpose

Maximum size of these dlls are 50Mb so we need to split included into two dlls.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@sm6srw sm6srw requested a review from mjkkirschner March 3, 2023 13:27
@sm6srw sm6srw merged commit fd68af1 into DynamoDS:master Mar 3, 2023
@sm6srw sm6srw deleted the Split_Included branch March 3, 2023 13:46
sm6srw added a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
@sm6srw
Split incuded (DynamoDS#13795)
8a0a4fa
sm6srw added a commit that referenced this pull request Apr 5, 2023
@sm6srw
Split incuded (#13795)
7b0ce86
dariaivanciucova pushed a commit to dariaivanciucova/Dynamo that referenced this pull request Apr 13, 2023
@sm6srw @dariaivanciucova
Split incuded (DynamoDS#13795)
242aa5e
dariaivanciucova added a commit to dariaivanciucova/Dynamo that referenced this pull request Apr 13, 2023
@dariaivanciucova
Revert "Split incuded (DynamoDS#13795)"
a81ec17 
This reverts commit 242aa5e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjkkirschner mjkkirschner mjkkirschner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sm6srw @mjkkirschner