Enabling ShortcutBar items #13761
Merged
Enabling ShortcutBar items #13761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
QilongTang
reviewed
Feb 21, 2023
QilongTang
reviewed
Feb 21, 2023
Contributor
|
Why do we still have a cut-out for them if they are disabled? Can we remove the cut-out? @QilongTang |
Contributor
Agree, and also we do not have to disable the notification center at the startup page.. |
Contributor
Author
|
The Buttons behavior based on the scenarios are in the task @Jingyi-Wen per our discussion, Could you validate if the scope of this task is included in the 4180 please ? otherwise let us know if there is something to catch up thanks.
|
|
@jesusalvino Yes, this seemed to be included in https://jira.autodesk.com/browse/DYN-4180 since that task includes all the menu items that needed to be disabled. |
QilongTang
reviewed
Feb 28, 2023
QilongTang
reviewed
Feb 28, 2023
QilongTang
reviewed
Feb 28, 2023
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with a couple comments
QilongTang
approved these changes
Feb 28, 2023
QilongTang
added a commit
that referenced
this pull request
Feb 28, 2023
This reverts commit 39fd836.
QilongTang
added a commit
that referenced
this pull request
Feb 28, 2023
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* Enabling ShortcutBar items * Renaming property * Using Event instead of set property * Increasing scope and refactoring * Update properties scope
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
This reverts commit 39fd836.
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Enabling ShortcutBar items * Renaming property * Using Event instead of set property * Increasing scope and refactoring * Update properties scope
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improvement based on the task https://jira.autodesk.com/browse/DYN-5404
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@QilongTang
FYIs
@RobertGlobant20 @filipeotero