Skip to content

Conversation

@saintentropy
Copy link
Contributor

@saintentropy saintentropy commented Feb 9, 2023

Purpose

Suggested additions and updates to the #13659 PR which introduce service mode.

This PR adds:

  • Add ServiceMode Configuration to the NETCore builds
  • Ignores loading of preference file in service mode. Instead it loads the default PreferenceSettings. The XML read is prohibitively slow currently

This PR removes

  • No longer disable loading of extensions (including the package manger). We want packages to load and can disable loading in other ways.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Reviewers

@QilongTang @mjkkirschner @BogdanZavu

FYIs

[Option("CERLocation", Required = false, HelpText = "Specify the crash error report tool location on disk.")]
public string CERLocation { get; set; } = String.Empty;
[Option("ServiceMode", Required = false, HelpText = "Specify the service mode startup.")]
public bool ServiceMode { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I missed this, without the helptext, do we not display anything right now?

@saintentropy saintentropy merged commit 1c04c3a into DynamoDS:ServiceMode Feb 15, 2023
QilongTang added a commit that referenced this pull request Feb 16, 2023
* Service Mode Initial commit

* clean up

* Update

* Diable SearchModel in Service Mode

* add console output

* [DNM] DAAS draft  (#13677)

* Removing CanToggleLoginState (#13657)

* Dyn 5488 add horizontal scroll bar (#13661)

* DYN-5488-Add-Horizontal-Scrollbar

When showing the documentation for packages the PackageDetailView extension was not showing the horizontal scroll bar then I added a change so that will be shown when the content is bigger than the usual width.

* DYN-5488-Add-Horizontal-Scrollbar

The HorizontalScrollBar will be shown only in the DataGrid due that if is shown in the complete SideBar is showing a weird white box.

* Disable loading extensions and view extensions in service mode.

Co-authored-by: filipeotero <89042471+filipeotero@users.noreply.github.com>
Co-authored-by: Roberto T <61755417+RobertGlobant20@users.noreply.github.com>

* Clean up

* Clean up and skip more steps

* clean up

* clean up

* clean up

* clean up

* Fix Unit tests

* Clean up

* Unit tests

* unit tests

* Fix Unit tests

* Comments

* Service mode changes (#13739)

* Add ServiceMode to Linux

* Load extensions in service mode

* Do not load preference setting file in ServiceMode

---------

Co-authored-by: Craig Long <craig.long@autodesk.com>

---------

Co-authored-by: reddyashish <43763136+reddyashish@users.noreply.github.com>
Co-authored-by: filipeotero <89042471+filipeotero@users.noreply.github.com>
Co-authored-by: Roberto T <61755417+RobertGlobant20@users.noreply.github.com>
Co-authored-by: Craig Long <craig.long@autodesk.com>
Co-authored-by: Craig Long <craig.alan.long@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants