Skip to content

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Sep 16, 2022

Purpose

A minor visual update for the Graph Node Manager view extension. Removed mouse pressed behavior on the filter UI elements causing a flashing-white appearance, which was not consistent with the styling.

Change

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • removed flashing white color on mouse pressed for the filter UI element

Reviewers

@Amoursol

- removed flashing white color on mouse pressed for the filter ui element
@Amoursol Amoursol self-requested a review September 18, 2022 11:47
@QilongTang QilongTang merged commit 6e82a27 into DynamoDS:master Sep 19, 2022
@QilongTang QilongTang added this to the 2.17.0 milestone Sep 19, 2022
pinzart90 added a commit that referenced this pull request Sep 27, 2022
* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* Keep Node AutoComplete popup hidden when window deactivated (#13337)

* Keep Node AutoComplete popup hidden when window deactivated

* Add condition and null checks

* comments

Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com>
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
Co-authored-by: Deyan Nenov <dnenov@archilizer.com>
Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com>
Co-authored-by: Aaron (Qilong) <173288704@qq.com>
Co-authored-by: Aabishkar KC <aabishkar@gmail.com>
mjkkirschner added a commit that referenced this pull request Sep 28, 2022
…3343)

* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add some lacing tests that use arb rank params

* fix tests

1. Missing replication Longest/Shortest attribute
2. Fix result - wrap in list (like old VM)

Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com>
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
Co-authored-by: Deyan Nenov <dnenov@archilizer.com>
Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com>
Co-authored-by: Aaron (Qilong) <173288704@qq.com>
Co-authored-by: Aabishkar KC <aabishkar@gmail.com>
Co-authored-by: kirschm <michael.kirschner@autodesk.com>
aparajit-pratap added a commit that referenced this pull request Sep 28, 2022
* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com>
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
Co-authored-by: Deyan Nenov <dnenov@archilizer.com>
Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com>
Co-authored-by: Aaron (Qilong) <173288704@qq.com>
Co-authored-by: Aabishkar KC <aabishkar@gmail.com>
Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com>
Co-authored-by: kirschm <michael.kirschner@autodesk.com>
aparajit-pratap added a commit that referenced this pull request Sep 28, 2022
* add nunit test adapter for 2022 (#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>

* Filter Mouse Pressed Removed (#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (#13312)

* Update Node AutoComplete Dialog Visuals (#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (#13233)

* Dyn5272 (#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

* update replication test

Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com>
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
Co-authored-by: Deyan Nenov <dnenov@archilizer.com>
Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com>
Co-authored-by: Aaron (Qilong) <173288704@qq.com>
Co-authored-by: Aabishkar KC <aabishkar@gmail.com>
Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com>
Co-authored-by: kirschm <michael.kirschner@autodesk.com>
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Jan 20, 2023
…namoDS#13343)

* add nunit test adapter for 2022 (DynamoDS#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>

* Filter Mouse Pressed Removed (DynamoDS#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (DynamoDS#13312)

* Update Node AutoComplete Dialog Visuals (DynamoDS#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (DynamoDS#13233)

* Dyn5272 (DynamoDS#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (DynamoDS#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (DynamoDS#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add some lacing tests that use arb rank params

* fix tests

1. Missing replication Longest/Shortest attribute
2. Fix result - wrap in list (like old VM)

Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com>
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
Co-authored-by: Deyan Nenov <dnenov@archilizer.com>
Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com>
Co-authored-by: Aaron (Qilong) <173288704@qq.com>
Co-authored-by: Aabishkar KC <aabishkar@gmail.com>
Co-authored-by: kirschm <michael.kirschner@autodesk.com>
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Jan 20, 2023
* add nunit test adapter for 2022 (DynamoDS#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>

* Filter Mouse Pressed Removed (DynamoDS#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (DynamoDS#13312)

* Update Node AutoComplete Dialog Visuals (DynamoDS#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (DynamoDS#13233)

* Dyn5272 (DynamoDS#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (DynamoDS#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (DynamoDS#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com>
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
Co-authored-by: Deyan Nenov <dnenov@archilizer.com>
Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com>
Co-authored-by: Aaron (Qilong) <173288704@qq.com>
Co-authored-by: Aabishkar KC <aabishkar@gmail.com>
Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com>
Co-authored-by: kirschm <michael.kirschner@autodesk.com>
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Jan 20, 2023
* add nunit test adapter for 2022 (DynamoDS#13313)

* add nunit test adapter for 2022

* update

* Update Setup.cs

* update

* Update DynamoCore.csproj

* Create System.Net.Http.dll

* update

* update

Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>

* Filter Mouse Pressed Removed (DynamoDS#13319)

- removed flashing white color on mouse pressed for the filter ui element

* Fixing horizontal center (DynamoDS#13312)

* Update Node AutoComplete Dialog Visuals (DynamoDS#13329)

* Update Node AutoComplete Visuals

* Reuse style from central location

* Add editorconfig (DynamoDS#13233)

* Dyn5272 (DynamoDS#13334)

tests pass - merging this then will send cherry pick

* Dyn 5159 import export preferences (DynamoDS#13301)

* Import Export Settings

* Info Icons

* Indentation

* Using Dynamo View Model reference

* Moving the methods to the proper places according to their accessibility

* Handling Generic Exceptions

* updating the RaisePropertyChanged

* Extracting the import extension file as a variable

* Unique file name

* Changing the access level

* Various revisions

* Cleaning vars

* Adding Unit Test

* Adding Comments and cleaning vars

* Removing unnecessary methods

* Refactoring to get the static fields automatically

* Updating the Unit Test

* checking new settings file

* Adding validation info

* Getting First Property with the same value

* Updating valid TrustedLocations entries

* move near clipping plane further away for more depth buffer precision. (DynamoDS#13338)

passed here:
merging.

* add more failing tests

* implement case 2 of replication

* Update ReplicationTests.cs

* add failing test

* add some more failing tests

* add replication test

* fix merge conflict

* fix merge conflict

* update replication test

Co-authored-by: pinzart90 <46732933+pinzart90@users.noreply.github.com>
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
Co-authored-by: Deyan Nenov <dnenov@archilizer.com>
Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com>
Co-authored-by: Aaron (Qilong) <173288704@qq.com>
Co-authored-by: Aabishkar KC <aabishkar@gmail.com>
Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com>
Co-authored-by: kirschm <michael.kirschner@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants