Skip to content

Dyn 5055 close guided tour switch workspace #13180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
Aug 5, 2022
Merged

Dyn 5055 close guided tour switch workspace #13180

QilongTang merged 2 commits into from
Aug 5, 2022

Conversation

@filipeotero
Copy link
Contributor

@filipeotero filipeotero commented Aug 5, 2022

Purpose

This PR implements the improvement that exits the tour (if started) when a new workspace is created.

ExitGuidedTourNewWorkspace

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@RobertGlobant20

@QilongTang
Copy link
Contributor

QilongTang commented Aug 5, 2022

No new regressions brought to master, merging

@QilongTang QilongTang merged commit 5d18d76 into DynamoDS:master Aug 5, 2022
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Aug 10, 2022
@reddyashish
Revert "setting exit tour method to internal and calling it when a ne…
7ee5548 
…w workspace is set (DynamoDS#13180)"

This reverts commit 5d18d76.
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Aug 10, 2022
@reddyashish
Revert "setting exit tour method to internal and calling it when a ne…
26e0740 
…w workspace is set (DynamoDS#13180)"

This reverts commit 5d18d76.
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Aug 11, 2022
@reddyashish
Revert "setting exit tour method to internal and calling it when a ne…
53452d8 
…w workspace is set (DynamoDS#13180)"

This reverts commit 5d18d76.
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Aug 11, 2022
@reddyashish
Revert "setting exit tour method to internal and calling it when a ne…
c69c298 
…w workspace is set (DynamoDS#13180)"

This reverts commit 5d18d76.
@reddyashish reddyashish mentioned this pull request Aug 11, 2022
Merged
8 tasks
QilongTang pushed a commit that referenced this pull request Aug 11, 2022
@reddyashish
Revert "setting exit tour method to internal and calling it when a ne…
db66e15 
…w workspace is set" (#13180) (#13204)

* Revert "setting exit tour method to internal and calling it when a new workspace is set (#13180)"

This reverts commit 5d18d76.

* Calling exit tour method only in non-test mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@filipeotero @QilongTang