temp fix for builds, remove tsplines nodes docs #12693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks, please fill N/A for the release notes |
QilongTang
approved these changes
Mar 14, 2022
sm6srw
approved these changes
Mar 14, 2022
aparajit-pratap
added a commit
to aparajit-pratap/Dynamo
that referenced
this pull request
Jun 8, 2022
…)" This reverts commit 9338ca4.
aparajit-pratap
added a commit
that referenced
this pull request
Jun 9, 2022
mjkkirschner
added a commit
that referenced
this pull request
Jun 16, 2022
QilongTang
pushed a commit
that referenced
this pull request
Jun 16, 2022
sm6srw
added a commit
to sm6srw/Dynamo
that referenced
this pull request
Dec 1, 2022
…)" This reverts commit 9338ca4.
sm6srw
added a commit
that referenced
this pull request
Dec 6, 2022
…es that are too long. (#13588) * Initial implementation * Remove files added by mistake. * Revert .gitignore change * Update help text * Add the original base name as a comment in the renamed MD file * Revert "temp fix for builds, remove tsplines nodes docs (#12693)" This reverts commit 9338ca4. * Rename offending files * Add hash test * Add tests for markdown generator tool * Update Readme * Add comments * Revert "Rename offending files" This reverts commit b09be40. * Use SHA256/Base32 instead of SHA1 * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently performance CI job, and WPF visualization - perf machine test jobs are down - it appears both have to do with the new docs files that have extremely long file names, like:
doc/distrib/NodeHelpFiles/Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.ByBoxLengths(origin, width, length, height, xSpans, ySpans, zSpans, symmetry, inSmoothMode).mdThis PR simply removes the 3 files with the longest file names. There are some others, but I want to remove the minimal set for now.
I will file a followup task to consider solutions to this issue in the docs browser and docs generator tools. I'm thinking something like generating a unique short name using a guid, standard hash, or some short name scheme etc.
There are other solutions as well for the nodes we maintain, like storing them in a binary file/resx which the docs browser parses at runtime.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
NA
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of