Skip to content

Conversation

@mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Oct 19, 2021

Purpose

  • Updates Greg.dll (package manager client) and RestSharp references - verified that downloads from DPM are using TLS 1.2 in sandbox.
  • Removes Greg and Restsharp references from LibraryViewExtension - not sure why these were needed - but verified it still builds (even though it is removed from the .sln)
  • Removes RestSharp reference from ViewExtensionLibraryTests

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

@mjkkirschner
Copy link
Member Author

mjkkirschner commented Oct 19, 2021

@mjkkirschner mjkkirschner merged commit b324cce into DynamoDS:master Oct 20, 2021
QilongTang pushed a commit that referenced this pull request Mar 25, 2022
* add null checking to method

* remove greg and rest sharp deps from libraryviewextension

* remove viewextenlibTests ref on restsharp

* updated ref to greg and restsharp - this builds but targets net452 version of restsharp

* update to latest greg version

* revert shared info version

* fix bad merge conflict and bad hint path

* fix

Co-authored-by: michael kirschner <michael.kirschner@autodesk.com>
QilongTang added a commit that referenced this pull request Mar 25, 2022
* Update Greg.dll and Restsharp (#12165)

* add null checking to method

* remove greg and rest sharp deps from libraryviewextension

* remove viewextenlibTests ref on restsharp

* updated ref to greg and restsharp - this builds but targets net452 version of restsharp

* update to latest greg version

* revert shared info version

* fix bad merge conflict and bad hint path

* fix

Co-authored-by: michael kirschner <michael.kirschner@autodesk.com>

* Switch to 2019 VS build machine

* Update Build Number

Co-authored-by: Michael Kirschner <mjk.kirschner@gmail.com>
Co-authored-by: michael kirschner <michael.kirschner@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants