Update base images for image comparison tests after anti-aliasing fix #11069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good but just curious all images doubled the size in this PR? Do we know why? |
8 tasks
Contributor
Author
The images are definitely better in quality so it could be that they are bigger in size for that reason. |
QilongTang
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is in continuation of #11068. Fixes 2 regressions in image comparison tests on account of #11068.
The images used for the image comparison tests need to be updated after turning on anti-aliasing. They look a lot better now :)
Declarations
Needs to be cherry-picked into RC2.8_master branch.
*.resxfilesReviewers
@QilongTang