Turn on Anti-aliasing in Helix #11068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
approved these changes
Aug 27, 2020
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
Left one looks much better! Thanks!
8 tasks
aparajit-pratap
added a commit
to aparajit-pratap/Dynamo
that referenced
this pull request
Aug 27, 2020
8 tasks
aparajit-pratap
added a commit
that referenced
this pull request
Aug 28, 2020
* [DYN-2988] Add custom fixer for instance.None (#11022) * add custom fixer for instance.None * cleanup * cleanup * add post build step to copy custom fixers to output directory * add unit test * review comments * edit fixer code comments * turn on anti-aliasing (#11068) * update base images for image comparison tests after anti-aliasing fix
aparajit-pratap
added a commit
that referenced
this pull request
Sep 2, 2020
* [DYN-2988] Add custom fixer for instance.None (#11022) * add custom fixer for instance.None * cleanup * cleanup * add post build step to copy custom fixers to output directory * add unit test * review comments * edit fixer code comments * turn on anti-aliasing (#11068) * update base images for image comparison tests after anti-aliasing fix * Guard against parser errors detected while migrating python code (#11080) * guard against parser errors detected while migrating python code * transfer Error state between side-by-side and inline diff views * revert whitespace in unchanged file * disable accept button for error state * update migration message * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-3087
Anti-aliasing has been disabled by default in newer versions of Helix, which explains the regression in the quality of curve rendering in 2.7 (see helix-toolkit/helix-toolkit#530). This has been turned on explicitly to fix the issue. This may have some performance impact but I don't think it should be significant considering it was on by default prior to 2.7 and we have made other performance gains after that with the helix pipeline.
The image on the left is with anti-aliasing on in my latest build. The one on the right is the current state:
Declarations
This needs to be cherry-picked into RC_2.8 branch
*.resxfiles