missed some property change notifications to update view #11023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mjkkirschner I guess the Python engine option is directly binded so it is handled correctly already on view level? |
QilongTang
approved these changes
Aug 19, 2020
Member
Author
|
The PythonNode works because it's bound directly to the property on the NodeModel instead of being bound to a proxy property on the ViewModel. |
Member
Author
|
@QilongTang did the tests pass here? |
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Aug 19, 2020
Contributor
|
@mjkkirschner The self CI did not get triggered. I only saw the SonarQube scan which I think is not necessary, did I miss something? |
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Aug 19, 2020
mjkkirschner
added a commit
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
During testing @smangarole noted that the UI was not being updated for
showLabelsorIsInputorIsOutputcheckboxes when undoing - I found that the tests are passing because the state is actually being correctly undone - but the UI was not being updated.Two properties were missing and one was misspelled.
Declarations
Check these if you believe they are true
*.resxfiles