Mesh display using shaders #10462
Merged
Mesh display using shaders #10462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,2b308956"
…DS#10026) * fast path for zero size heap allocation * Cache mechanism for marshalling lookups * Do not allocate heap stack values for class properties for CLR objects * Test removing getter heap interaction for CLR object * Remove unused Heap Object set * make variables non-static * remove GetterFunctionPointer class Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com>
* search for property by getter if not found * add test
* Add geometry color check for Display_ByGeometryColor_HasColoredMesh Add geometry color check for Display_ByGeometryColor_HasColoredMesh * Test updates * Add Geometry Transparency Test * Update test name
* fix for crash upon unresolved node undo * override Equals in PortModel * add recorded test
* DYN-2328 Add test for geometry lablling * DYN-2328 Add test for geometry labeling * Removing extra assignments * updating the test and the test dyn file. * Removing the extra variable that is not being used
This Github Action will greet Github users who submit a PR or issue first time to our repo
* Initial Commit to Update Analytics Agreement Workflow * update * Add unit test for deserializing analytics setting * Update instrumentation default agreement setting in unit test * Add more comments
* "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,5c8f1fdd"
…moDS#10316) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button.
…when using display scaling (DynamoDS#10335) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * Unsubscribing the event handler in dispose method
* Skip Analytics Client Tear down if it is not needed * Add unit test covering analytics tear down * Touch test naming
* Update Tracking Conditions * Add same check to ReportingUsage * Add properties comments
1. Unsubscribe DpiChanged event handler in the browser Dispose method. 2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time. 3. Add necessary comments.
isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate.
add cleanup to color cache
fix watch3d background color test fix watch3d image export function
… function in helix does not work.
need to rerun tests
all tests pass
Contributor
|
@mjkkirschner can you merge all changes from |
Member
Author
|
@aparajit-pratap yes - I will do that now. |
…termerge # Conflicts: # src/DynamoUtilities/CertificateVerification.cs # src/VisualizationTests/HelixWatch3DViewModelTests.cs # test/DynamoCoreWpfTests/CoreUITests.cs
fix comment and some todos
# Conflicts: # src/VisualizationTests/HelixWatch3DViewModelTests.cs
Member
Author
|
also tested transformable interface - that is working as well: |
7 tasks
| protected void AddDynamoTechniques() | ||
| { | ||
| var custom = new TechniqueDescription("RenderCustom") | ||
| var dynamoCustomMeshTech = new TechniqueDescription(DynamoCustomShaderNames.DynamoCustomMeshShader) |
Contributor
There was a problem hiding this comment.
Minor but how about making the DynamoCustomMeshShader string internal static to DynamoEffectsManager rather than having a new class just for it?
Member
Author
|
@reddyashish @aparajit-pratap please take a look, I have addressed the current comments I believe. |
reddyashish
reviewed
Mar 18, 2020
| // handles determining color of elementGeometry3Ds when any property is set false | ||
| // as the state of other properties must be checked to determine the correct color / material. | ||
| private static void OnPropertySetFalse(DependencyObject obj) | ||
| private static void OnPoint_Line_PropertySetFalse(DependencyObject obj) |
Contributor
There was a problem hiding this comment.
Just a minor thing but I think it is better to avoid underscore character for function names unless they are test functions. Makes it easy to differentiate.
https://stackoverflow.com/questions/9782084/naming-conventions-in-c-sharp-underscores
https://docs.microsoft.com/en-us/dynamicsax-2012/developer/naming-conventions-underscores.
Contributor
|
@mjkkirschner Just one small comment but looks good to me. |
Contributor
|
@mjkkirschner thanks for addressing the review comments and answering my questions. I think this is a very clean approach. Excellent work 👍 |
Member
Author
|
@reddyashish comments addressed - are we good to go? |
QilongTang
added a commit
that referenced
this pull request
May 12, 2020
* Move to Helix 2.5.1 and SharpDX 4.2.0 * Re-implement zoom in/out buttons * Upgrade Helix to 2.9.0 * Re-implement headlight outside of shader * Remove Helix shader pipeline customizations, use default shaders (WIP) * restore updating colors for selected and frozen node states * code cleanup * Use Viewport3DX.Items, enable geometry -> node selection * Helix upgrade basics (#10326) * [DYN-2349] Close workspace references extension tab by user action and API (#10230) * DYN-2349 * Adding events and fixing the crash that was happening due to selection/deselection of the menu item. * Change to internal * Moving the Close tab event from ViewLoadedParams to WorkspaceDependencyView call * Adding extension tab name as an input parameter to the Close Extension event * Adding null check for WorkspaceReferencesMenuItem * Making the extension name string a constant * Removing the extra line * Dyn 2303 (#10277) * Add Category ExcelTest. * Update ExcelTests.cs * Add new LibraryViewExtension project based on System.Windows.Controls.WebBrowser (#10241) * add new project add make core internals visible add duplicate files as required * build of libjswebview seems to work added package references * add resource files as links so dont duplicate them in repo * move to .net 4.7.2 to avoid package ref issues namespace adds dynamo use new namespace to reference resources that are embedded. * move back to 4.7 to see if we can get a build on self serve * log msbuild version in appyveyor * try using buildxml which restores a bit differently * image should not be under env - bah * revet back to nuget restore and build dynamo all * working branch in acad * icons from host registered streams supported now * this functions but startup time is slow. visibility fixed with startPage loads acad icons from resource streams that are registered using existing resource dict * add some stopwatch logging to resource loading remove superflous resourcestream handler add cache to main iconProvider entrypoint as first step in resolving icon data use string builder to construct base64 data strings * missed changes * semi working lazy load - small change made to librariejs to raise event whenever any item is clicked we also cache the original url before falling back to the default icon so we can load the real icon later. * some cleanup * update namespace to reflect what components are actually used update some todos update comments * drop back to packges config rename project, rename folder rename extension class * assembly and type names changed * remove value tuple use set version number to auto increment for now - keep at 1.0.x until we have a longer term plan for this project * get rid of value tuple * recase some methods comments add readme * address review comments * Add new tests (#10279) * Revert "Reset engine controller for every new workspace (#10113)" (#10282) This reverts commit b01e2de. * DYN-2375 - Event to handle the close operation of the workspace references extension (#10280) * First commit * new changes * Renaming the event * Adding test * Upgrade Revit Sample file to Revit 2021 (#10288) * pass the additional to sign list to the installerspec generator (#10285) add new files add comments remove files that no longer exist update installerSpec.exe update installerspec source * points and curves render bounds are updated when added - and faster than for each RP. remove new handlers and events, revert to binding. * revert change * remove commented out code * add comments * remove some old comments remove old code for testing Co-authored-by: reddyashish <43763136+reddyashish@users.noreply.github.com> Co-authored-by: manuelsaldivar525 <48363605+manuelsaldivar525@users.noreply.github.com> Co-authored-by: Aaron (Qilong) <aaron.tang@autodesk.com> Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> Co-authored-by: ZiyunShang <33445445+ZiyunShang@users.noreply.github.com> * Helix upgrade PR to merge the changes from the master branch (#10388) * LibG Binaries Update (#10295) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,2b308956" * Change mechanism to retreive the certificate from assembly (#10301) * DYN-2225 - Marshaling Performance optimization - Heap Cleanup (#10026) * fast path for zero size heap allocation * Cache mechanism for marshalling lookups * Do not allocate heap stack values for class properties for CLR objects * Test removing getter heap interaction for CLR object * Remove unused Heap Object set * make variables non-static * remove GetterFunctionPointer class Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> * DYN-2289: Fix crash with NodeToCode (#10305) * search for property by getter if not found * add test * Geometry Color Tests More (#10291) * Add geometry color check for Display_ByGeometryColor_HasColoredMesh Add geometry color check for Display_ByGeometryColor_HasColoredMesh * Test updates * Add Geometry Transparency Test * Update test name * update newly added test (#10313) * DYN-2286: fix for crash upon unresolved node undo (#10315) * fix for crash upon unresolved node undo * override Equals in PortModel * add recorded test * DYN-2328 Add test for geometry labeling (#10311) * DYN-2328 Add test for geometry lablling * DYN-2328 Add test for geometry labeling * Removing extra assignments * updating the test and the test dyn file. * Removing the extra variable that is not being used * First Github Action (#10131) This Github Action will greet Github users who submit a PR or issue first time to our repo * Removal of PR trigger for now (#10323) * Analytics Agreement Workflow Update (#10314) * Initial Commit to Update Analytics Agreement Workflow * update * Add unit test for deserializing analytics setting * Update instrumentation default agreement setting in unit test * Add more comments * Add missing resource string (#10329) * LibG Binaries Update (#10331) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,5c8f1fdd" * Fix the library view display issues introduced by MS WebBrowser (#10316) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * [DYN-2382] LibraryViewExtensionMSWebBrowser does not scale correctly when using display scaling (#10335) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * Unsubscribing the event handler in dispose method * Skip GA Client Tear Down Process if NOT Necessary (#10340) * Skip Analytics Client Tear down if it is not needed * Add unit test covering analytics tear down * Touch test naming * [Analytics] Update Tracking Conditions (#10345) * Update Tracking Conditions * Add same check to ReportingUsage * Add properties comments * PR comment (#10347) * Code improvements: (#10348) 1. Unsubscribe DpiChanged event handler in the browser Dispose method. 2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time. 3. Add necessary comments. * Update HelixWatch3DViewModelTests.cs * Updating Watch3D_Disconnect_Reconnect_CorrectRenderings test Co-authored-by: DynamoEngOps <dynamo.engops@autodesk.com> Co-authored-by: Craig Long <craig.alan.long@gmail.com> Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> Co-authored-by: Aaron (Qilong) <aaron.tang@autodesk.com> Co-authored-by: StarLee <42235642+CoolStarLee@users.noreply.github.com> * [DYN-2341] Labels on helix-update branch cause slow down (#10399) * Fix the null pointer exception This will render the labels on the workspace without any lags. * Adding test to compare the performace. * Verify test run time. * some changes to the test. * Update comments * DYN-2406: better handle pts/lines when selecting, freezing, and isolating. (#10375) * working color change on selection for points. * lots of cleanup work to do but this works isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate. * start adding morecolor tests * fix test * add more tests add cleanup to color cache * fix watch3d background color converter fix watch3d background color test fix watch3d image export function * need to move branches - saving work * give up on image comparison tests, will file that as followup, resize function in helix does not work. * break out some util methods need to rerun tests * review comments all tests pass * review comment * improve performance of selection handler while isolation mode is on - no need to update scene items - modifying colors updates the materials and colors already. * fix color tests modify pt line isolation alpha * fix alpha value for mesh colors in isolation mode. (#10405) * working color change on selection for points. * lots of cleanup work to do but this works isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate. * start adding morecolor tests * fix test * add more tests add cleanup to color cache * fix watch3d background color converter fix watch3d background color test fix watch3d image export function * need to move branches - saving work * give up on image comparison tests, will file that as followup, resize function in helix does not work. * break out some util methods need to rerun tests * review comments all tests pass * review comment * improve performance of selection handler while isolation mode is on - no need to update scene items - modifying colors updates the materials and colors already. * fix color tests modify pt line isolation alpha * missed last alpha change * Helix upgrade mastermerge (#10465) * LibG Binaries Update (#10295) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,2b308956" * Change mechanism to retreive the certificate from assembly (#10301) * DYN-2225 - Marshaling Performance optimization - Heap Cleanup (#10026) * fast path for zero size heap allocation * Cache mechanism for marshalling lookups * Do not allocate heap stack values for class properties for CLR objects * Test removing getter heap interaction for CLR object * Remove unused Heap Object set * make variables non-static * remove GetterFunctionPointer class Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> * DYN-2289: Fix crash with NodeToCode (#10305) * search for property by getter if not found * add test * Geometry Color Tests More (#10291) * Add geometry color check for Display_ByGeometryColor_HasColoredMesh Add geometry color check for Display_ByGeometryColor_HasColoredMesh * Test updates * Add Geometry Transparency Test * Update test name * update newly added test (#10313) * DYN-2286: fix for crash upon unresolved node undo (#10315) * fix for crash upon unresolved node undo * override Equals in PortModel * add recorded test * DYN-2328 Add test for geometry labeling (#10311) * DYN-2328 Add test for geometry lablling * DYN-2328 Add test for geometry labeling * Removing extra assignments * updating the test and the test dyn file. * Removing the extra variable that is not being used * First Github Action (#10131) This Github Action will greet Github users who submit a PR or issue first time to our repo * Removal of PR trigger for now (#10323) * Analytics Agreement Workflow Update (#10314) * Initial Commit to Update Analytics Agreement Workflow * update * Add unit test for deserializing analytics setting * Update instrumentation default agreement setting in unit test * Add more comments * Add missing resource string (#10329) * LibG Binaries Update (#10331) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,5c8f1fdd" * Fix the library view display issues introduced by MS WebBrowser (#10316) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * [DYN-2382] LibraryViewExtensionMSWebBrowser does not scale correctly when using display scaling (#10335) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * Unsubscribing the event handler in dispose method * Skip GA Client Tear Down Process if NOT Necessary (#10340) * Skip Analytics Client Tear down if it is not needed * Add unit test covering analytics tear down * Touch test naming * [Analytics] Update Tracking Conditions (#10345) * Update Tracking Conditions * Add same check to ReportingUsage * Add properties comments * PR comment (#10347) * Code improvements: (#10348) 1. Unsubscribe DpiChanged event handler in the browser Dispose method. 2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time. 3. Add necessary comments. * add show line numbers when watermarkLabel is collapsed (#10362) * Visual Identifier on Optional Inputs (#10361) * change port text to italic if using default input * Update Ports.xaml * Update README.md (#10387) * Update README.md * Update README.md * Update README.md * Update DynamoVisualProgramming.Core.nuspec * Update DynamoVisualProgramming.Core.nuspec * GA client not launching when terms not agreed (#10407) * GA client not launching when terms not agreed * Comments * Patch 283 (#10421) * Add WinVerityTrust wrapper * Utilzie new WinTrustWrapper method for cert verification * Add negative test * Add Package with faked certificate * Create sub namespace for WinVerityInteropp * Update the WinTrustInterop * Upate method call name * Add specific exceptions to the CertificateVerfication class * formating * Cover Test for Configuration Folder (#10444) * Cover Test for Configuration Folder * Update DynamoCoreTests.csproj * Added a couple of asserts for the properties. (#10437) * Add Test for Properties and removed getter and setter from WorkspaceDependencyViewExtension.DependencyView property. * Update WorkspaceDependencyViewExtension.cs * Fix for crash while drawing Point manipulator (gizmo) when LibG fails to load (#10148) * fix for crash in DM when LibG fails to load * return from recursive loop once we find the first non-null point * cache enabled flag for manipulator * more fixes * add documentation * add documentation Co-authored-by: DynamoEngOps <dynamo.engops@autodesk.com> Co-authored-by: Craig Long <craig.alan.long@gmail.com> Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: reddyashish <43763136+reddyashish@users.noreply.github.com> Co-authored-by: StarLee <42235642+CoolStarLee@users.noreply.github.com> Co-authored-by: Sylvester Knudsen <sylvesterknudsen@gmail.com> * Mesh display using shaders (#10462) * LibG Binaries Update (#10295) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,2b308956" * Change mechanism to retreive the certificate from assembly (#10301) * DYN-2225 - Marshaling Performance optimization - Heap Cleanup (#10026) * fast path for zero size heap allocation * Cache mechanism for marshalling lookups * Do not allocate heap stack values for class properties for CLR objects * Test removing getter heap interaction for CLR object * Remove unused Heap Object set * make variables non-static * remove GetterFunctionPointer class Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> * DYN-2289: Fix crash with NodeToCode (#10305) * search for property by getter if not found * add test * Geometry Color Tests More (#10291) * Add geometry color check for Display_ByGeometryColor_HasColoredMesh Add geometry color check for Display_ByGeometryColor_HasColoredMesh * Test updates * Add Geometry Transparency Test * Update test name * update newly added test (#10313) * DYN-2286: fix for crash upon unresolved node undo (#10315) * fix for crash upon unresolved node undo * override Equals in PortModel * add recorded test * DYN-2328 Add test for geometry labeling (#10311) * DYN-2328 Add test for geometry lablling * DYN-2328 Add test for geometry labeling * Removing extra assignments * updating the test and the test dyn file. * Removing the extra variable that is not being used * First Github Action (#10131) This Github Action will greet Github users who submit a PR or issue first time to our repo * Removal of PR trigger for now (#10323) * Analytics Agreement Workflow Update (#10314) * Initial Commit to Update Analytics Agreement Workflow * update * Add unit test for deserializing analytics setting * Update instrumentation default agreement setting in unit test * Add more comments * Add missing resource string (#10329) * LibG Binaries Update (#10331) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,5c8f1fdd" * Fix the library view display issues introduced by MS WebBrowser (#10316) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * [DYN-2382] LibraryViewExtensionMSWebBrowser does not scale correctly when using display scaling (#10335) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * Unsubscribing the event handler in dispose method * working color change on selection for points. * Skip GA Client Tear Down Process if NOT Necessary (#10340) * Skip Analytics Client Tear down if it is not needed * Add unit test covering analytics tear down * Touch test naming * [Analytics] Update Tracking Conditions (#10345) * Update Tracking Conditions * Add same check to ReportingUsage * Add properties comments * PR comment (#10347) * Code improvements: (#10348) 1. Unsubscribe DpiChanged event handler in the browser Dispose method. 2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time. 3. Add necessary comments. * lots of cleanup work to do but this works isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate. * start adding morecolor tests * fix test * add more tests add cleanup to color cache * fix watch3d background color converter fix watch3d background color test fix watch3d image export function * need to move branches - saving work * give up on image comparison tests, will file that as followup, resize function in helix does not work. * break out some util methods need to rerun tests * review comments all tests pass * review comment * add show line numbers when watermarkLabel is collapsed (#10362) * Visual Identifier on Optional Inputs (#10361) * change port text to italic if using default input * Update Ports.xaml * Update README.md (#10387) * Update README.md * Update README.md * Update README.md * Update DynamoVisualProgramming.Core.nuspec * Update DynamoVisualProgramming.Core.nuspec * GA client not launching when terms not agreed (#10407) * GA client not launching when terms not agreed * Comments * Patch 283 (#10421) * Add WinVerityTrust wrapper * Utilzie new WinTrustWrapper method for cert verification * Add negative test * Add Package with faked certificate * Create sub namespace for WinVerityInteropp * Update the WinTrustInterop * Upate method call name * Add specific exceptions to the CertificateVerfication class * formating * fix summary * Cover Test for Configuration Folder (#10444) * Cover Test for Configuration Folder * Update DynamoCoreTests.csproj * Added a couple of asserts for the properties. (#10437) * Add Test for Properties and removed getter and setter from WorkspaceDependencyViewExtension.DependencyView property. * Update WorkspaceDependencyViewExtension.cs * this is working to link 2 simple shaders - they are just for testing though. (vertex shaders with lighting) embed testing shaders add technique that uses our 2 shaders add core and node classes for dynamo mesh which will set data on shader based on attached properties. * Fix for crash while drawing Point manipulator (gizmo) when LibG fails to load (#10148) * fix for crash in DM when LibG fails to load * return from recursive loop once we find the first non-null point * cache enabled flag for manipulator * more fixes * add documentation * add documentation * update shader names add handle mesh method to attached properties replacing all the material setting add code for setting bit flags and setting data on struct that actually makes it to shader add helix shader structs and functions that we need to compile our shaders add readme * fix broken tests dude to bad merge conflict fix * remove commented out vertex shader code * fix bug in shader fix comment and some todos * remove tested transofmrable interface * update comments * review comments * review comments2 Co-authored-by: DynamoEngOps <dynamo.engops@autodesk.com> Co-authored-by: Craig Long <craig.alan.long@gmail.com> Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: reddyashish <43763136+reddyashish@users.noreply.github.com> Co-authored-by: StarLee <42235642+CoolStarLee@users.noreply.github.com> Co-authored-by: Sylvester Knudsen <sylvesterknudsen@gmail.com> * Headlight bound to Camera LookDirection (#10466) * LibG Binaries Update (#10295) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,2b308956" * Change mechanism to retreive the certificate from assembly (#10301) * DYN-2225 - Marshaling Performance optimization - Heap Cleanup (#10026) * fast path for zero size heap allocation * Cache mechanism for marshalling lookups * Do not allocate heap stack values for class properties for CLR objects * Test removing getter heap interaction for CLR object * Remove unused Heap Object set * make variables non-static * remove GetterFunctionPointer class Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> * DYN-2289: Fix crash with NodeToCode (#10305) * search for property by getter if not found * add test * Geometry Color Tests More (#10291) * Add geometry color check for Display_ByGeometryColor_HasColoredMesh Add geometry color check for Display_ByGeometryColor_HasColoredMesh * Test updates * Add Geometry Transparency Test * Update test name * update newly added test (#10313) * DYN-2286: fix for crash upon unresolved node undo (#10315) * fix for crash upon unresolved node undo * override Equals in PortModel * add recorded test * DYN-2328 Add test for geometry labeling (#10311) * DYN-2328 Add test for geometry lablling * DYN-2328 Add test for geometry labeling * Removing extra assignments * updating the test and the test dyn file. * Removing the extra variable that is not being used * First Github Action (#10131) This Github Action will greet Github users who submit a PR or issue first time to our repo * Removal of PR trigger for now (#10323) * Analytics Agreement Workflow Update (#10314) * Initial Commit to Update Analytics Agreement Workflow * update * Add unit test for deserializing analytics setting * Update instrumentation default agreement setting in unit test * Add more comments * Add missing resource string (#10329) * LibG Binaries Update (#10331) * "LibG/ASM224,7418555f" * "LibG/ASM224.4,918b3d73" * "LibG/ASM225,2b68d3dd" * "LibG/ASM226,5c8f1fdd" * Fix the library view display issues introduced by MS WebBrowser (#10316) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * [DYN-2382] LibraryViewExtensionMSWebBrowser does not scale correctly when using display scaling (#10335) * Disable the context menu on the library viewer. * Zoom the libarary view to adapt the current DPI scale. * Disable the horizontal scroll bar on the bottom of the library view. * Disable the library view is zoomed by keyboard or mouse wheel. * Zoom the library bar to adapt the current DPI scale. * Hide the extra search text bar close button. * Unsubscribing the event handler in dispose method * working color change on selection for points. * Skip GA Client Tear Down Process if NOT Necessary (#10340) * Skip Analytics Client Tear down if it is not needed * Add unit test covering analytics tear down * Touch test naming * [Analytics] Update Tracking Conditions (#10345) * Update Tracking Conditions * Add same check to ReportingUsage * Add properties comments * PR comment (#10347) * Code improvements: (#10348) 1. Unsubscribe DpiChanged event handler in the browser Dispose method. 2. Move the overflow-x style setting from script to html to avoid to set it when the script method is called every time. 3. Add necessary comments. * lots of cleanup work to do but this works isolate correctly sets all geo to low alpha, and the selected geo sets back to whatever other state it was in without isolate. * start adding morecolor tests * fix test * add more tests add cleanup to color cache * fix watch3d background color converter fix watch3d background color test fix watch3d image export function * need to move branches - saving work * give up on image comparison tests, will file that as followup, resize function in helix does not work. * break out some util methods need to rerun tests * review comments all tests pass * review comment * add show line numbers when watermarkLabel is collapsed (#10362) * Visual Identifier on Optional Inputs (#10361) * change port text to italic if using default input * Update Ports.xaml * Update README.md (#10387) * Update README.md * Update README.md * Update README.md * Update DynamoVisualProgramming.Core.nuspec * Update DynamoVisualProgramming.Core.nuspec * GA client not launching when terms not agreed (#10407) * GA client not launching when terms not agreed * Comments * Patch 283 (#10421) * Add WinVerityTrust wrapper * Utilzie new WinTrustWrapper method for cert verification * Add negative test * Add Package with faked certificate * Create sub namespace for WinVerityInteropp * Update the WinTrustInterop * Upate method call name * Add specific exceptions to the CertificateVerfication class * formating * fix summary * Cover Test for Configuration Folder (#10444) * Cover Test for Configuration Folder * Update DynamoCoreTests.csproj * Added a couple of asserts for the properties. (#10437) * Add Test for Properties and removed getter and setter from WorkspaceDependencyViewExtension.DependencyView property. * Update WorkspaceDependencyViewExtension.cs * this is working to link 2 simple shaders - they are just for testing though. (vertex shaders with lighting) embed testing shaders add technique that uses our 2 shaders add core and node classes for dynamo mesh which will set data on shader based on attached properties. * Fix for crash while drawing Point manipulator (gizmo) when LibG fails to load (#10148) * fix for crash in DM when LibG fails to load * return from recursive loop once we find the first non-null point * cache enabled flag for manipulator * more fixes * add documentation * add documentation * update shader names add handle mesh method to attached properties replacing all the material setting add code for setting bit flags and setting data on struct that actually makes it to shader add helix shader structs and functions that we need to compile our shaders add readme * fix broken tests dude to bad merge conflict fix * remove commented out vertex shader code * fix bug in shader fix comment and some todos * remove tested transofmrable interface * update comments * fix binding add test * flip normal if back facing tri update shader * make sure compiled shader up to date. Co-authored-by: DynamoEngOps <dynamo.engops@autodesk.com> Co-authored-by: Craig Long <craig.alan.long@gmail.com> Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> Co-authored-by: Aaron (Qilong) <173288704@qq.com> Co-authored-by: reddyashish <43763136+reddyashish@users.noreply.github.com> Co-authored-by: StarLee <42235642+CoolStarLee@users.noreply.github.com> Co-authored-by: Sylvester Knudsen <sylvesterknudsen@gmail.com> * special render packages should render with materials colors only (#10481) * special render packages should render with materials add test update shader * fix comment * update comments * Update ProtoGeometry.config (#10483) * Avoid rendering Gizmo multiple times on rotate (#10479) A change of behavior in helix when upgrading from v2015 is that the CameraChanged event gets fired several times, once for each individual property of Camera that changed. In order to avoid rendering the Gizmo several times, which leads to choppy camera rotation, we limit the rendering of the Gizmo to only be done when the position of the camera changed. Use C# 6 to support build machines * add 3d graphics image comparison tests (#10487) * special render packages should render with materials add test update shader * fix comment * update comments * lower intensity of directional light add new image comp tests add new color dyn files that are easy to modify on the fly add first set of reference images * add new tests add ref images all pass local * comment * refactor tests correct comment * unused usings * target shader model 4 to avoid crash when user does not have GPU. (#10497) * special render packages should render with materials add test update shader * fix comment * update comments * lower intensity of directional light add new image comp tests add new color dyn files that are easy to modify on the fly add first set of reference images * add new tests add ref images all pass local * comment * drop to shader model 4 to avoid crash on WARP devices * fix shader interpolation and make image comparison tests more tolerant. (#10506) * add debug save image mode add percent diff assertion add log of percent and each diff * enable save fix build errors fix path errors * update shaders to fix them on WARP/real hardware remove dynamo ps input add color distance and percent dist check to make tests more tolerant of changes * rename function, rename params * Handle memory outage on render (cherry pick) (#10569) This brings the fix from master to the helix-upgrade branch. The only difference is that the test now mocks the AggregateRenderPackage function directly, because the function mocked in master no longer exists. The visibility was changed to internal virtual in order to be able to mock it, also using InternalsVisibleTo. * Add Image Comparison Test for Surface. (#10579) * Added Surface image comparison test and corrected indentation * Update to include .sat file * Format code lines * Remove Dup entry * Comments * Comments * Comments * Revert test file name change Co-authored-by: Michael Dewberry <michael.dewberry@autodesk.com> Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com> Co-authored-by: michael kirschner <mjk.kirschner@gmail.com> Co-authored-by: reddyashish <43763136+reddyashish@users.noreply.github.com> Co-authored-by: manuelsaldivar525 <48363605+manuelsaldivar525@users.noreply.github.com> Co-authored-by: ZiyunShang <33445445+ZiyunShang@users.noreply.github.com> Co-authored-by: DynamoEngOps <dynamo.engops@autodesk.com> Co-authored-by: Craig Long <craig.alan.long@gmail.com> Co-authored-by: StarLee <42235642+CoolStarLee@users.noreply.github.com> Co-authored-by: Sylvester Knudsen <sylvesterknudsen@gmail.com> Co-authored-by: Martin Misol Monzo <mmisol@users.noreply.github.com> Co-authored-by: Ashish Aggarwal <aggarwal.ash@husky.neu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR brings Dynamo's customer shader implementation into helix 2.9 (btw 2.11 is out and we can upgrade pretty easily yay!)
I tried various other solutions but the matrix of features and drawing modes is quite large - to get them all working together without a shader is IMO - more complex, and way less performant than with one.
PR does the following:
merges in master to helix-upgrade branch (sorry for that noise) if required I can send that as a separate PR to make this diff smaller.removes our use of materials for mesh drawing - only one material is now used. The others are made internal and only kept around to refer to their properties.
adds the
DynamoGeometryMeshCoreandDynamoGeometryNodeclasses which follow the helix customShaderDemo pattern to pick a custom shader for a GeometryModel and send data to that shader on a per model basis. Ie is this model frozen or not.Data is sent as a bit packed float - in the shader that gets cast to an int and decoded with a binary & - for more info on bitmasks see here: https://en.wikipedia.org/wiki/Mask_(computing)
Some flags are not currently used - these are marked as such, but I think they could be useful.
adds a script to compile the shaders - with comments
adds a readme about updating the shaders in the future
adds the compiled shaders and embeds them into DynamoCoreWPF - these are loaded with the DynamoEffectsManager class as byte arrays.
adds 3 files from helix's built in shader so that we can access common datastructures that helix passes to all shaders. I removed all other helix refs.
adds two shader .hlsl files - one vertex shader and fragment shader - these are only used for Dynamo meshes. Points and lines continue to use the builtin helix shader and materials - we can consider changing these later (or next), but in my testing performance was fairly good for points/lines with the current implementation. No doubt it could be faster with a shader.
Reverts a few things to avoid any unnecessary API breaks. I know there are still issues we cannot solve because of helix type changes.
TODO - there are various TODOs I have added that I will address ASAP.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of