Skip to content

Conversation

@mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Nov 23, 2019

Purpose

This was an experiment in embedding the necessary code from https://github.com/microsoft/XamlBehaviorsWpf which is MIT licensed. (this is the new open source version of system.windows.interactivity)

and wrapping that in our own namespace in DynamoCoreWPF. It works, it should be way more solid, performant, and memory stable than whatever workaround we can come up with - but it's ugly and a maintenance issue to have this code here...

It makes me think the best course of action might be to just update the sys.win.int 3.x (align with Revit) for now - and at the next major release switch to consuming xaml.behaviors.wpf instead.

feedback on these two PRs is appreciated.
#10162

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@mjkkirschner
Copy link
Member Author

mjkkirschner commented Nov 25, 2019

we may also be able to take the existing dll, modify it with something like mono.cecil and re-export it with a different name, so that we don't need to keep building the code or keep it here.
I'm not sure how the exceptionStringTable bit would work, but we can look at that in the future.

https://github.com/jbevain/cecil/wiki/HOWTO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant