get ready for removal of sys.win.int - embed xaml.behaviors.wpf EventTrigger #10163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This was an experiment in embedding the necessary code from https://github.com/microsoft/XamlBehaviorsWpf which is MIT licensed. (this is the new open source version of system.windows.interactivity)
and wrapping that in our own namespace in DynamoCoreWPF. It works, it should be way more solid, performant, and memory stable than whatever workaround we can come up with - but it's ugly and a maintenance issue to have this code here...
It makes me think the best course of action might be to just update the sys.win.int 3.x (align with Revit) for now - and at the next major release switch to consuming
xaml.behaviors.wpfinstead.feedback on these two PRs is appreciated.
#10162
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of