Skip to content

get ready for removal of sys.win.int - manually hookup events #10162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjkkirschner wants to merge 5 commits into from
Closed

get ready for removal of sys.win.int - manually hookup events #10162

mjkkirschner wants to merge 5 commits into from

Conversation

@mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Nov 23, 2019 •
edited
Loading

Purpose

One approach to removing system.windows.Interactivity -
it's ugly and brittle but it does load - and mostly works...

when the portViewModel collection is modified we hook up some event handlers and redirect these to the commands they are intended to call on the portViewmodel...

We need to keep track of the observableCollection of portViewModels and remove the handlers etc etc.

meh.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@mjkkirschner mjkkirschner mentioned this pull request Nov 23, 2019
Closed
7 tasks
@mjkkirschner mjkkirschner changed the title get ready for removal of sys.win.int - use manual events get ready for removal of sys.win.int - manually hookup events Nov 23, 2019
@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Nov 25, 2019

@mjkkirschner what is the change you've made to the sys.win.int binary? Should it not be removed in this PR?

@mjkkirschner
Copy link
Member Author

mjkkirschner commented Nov 25, 2019 •
edited
Loading

Hey @aparajit-pratap - I forgot to include this in the PR descriptions, but have mentioned it a few times - it's arguable if we can remove the dll at this time completely as we still have a public type that inherits from it

HandlingEventTrigger : System.Windows.Interactivity.EventTrigger

it's kind of an odd case as it's in DynamoCoreWPF and is used in our views, but someone could have used or derived from this type.

So my change to that dll was to update it to the 3.x version.

I should add the obsolete attribute to that type here.

@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Nov 25, 2019

Hey @aparajit-pratap - I forgot to include this in the PR descriptions, but have mentioned it a few times - it's arguable if we can remove the dll at this time completely as we still have a public type that inherits from it

Oh so you've just updated the version here?

@mjkkirschner
Copy link
Member Author

mjkkirschner commented Nov 25, 2019

yes updated the version - and while the HandlingEventTrigger type is still here, it's no longer used.

@mjkkirschner mjkkirschner mentioned this pull request Nov 25, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mjkkirschner @aparajit-pratap