Skip to content

Conversation

@aparajit-pratap
Copy link
Contributor

Purpose

Cherry-pick #10083

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

FYIs

@saintentropy

aparajit-pratap and others added 5 commits November 19, 2019 16:08
* remove LibG223 dir

* add support for LibG for ASM226, remove 223 references from code
…tting element bound Revit nodes to update (DynamoDS#10083)

* Add Map for Node guids to Callsite identifier strings

* Load RuntimeData map for Node guids to Callsite identifier strings on Callsite construction

* look up matching callsites directly for a node Guid with maps versus interaction with instruction stream data

* Add test to validate map for node to callsite identifier is intialized and used correctly

* Remove c#7 inline out variable declaration

* remove more inline declaration

* Remove graphnode check

* Change map from callsiteIdentifier to callsite object

* Update test strings

* make new property internal

* add code comments
@aparajit-pratap aparajit-pratap merged commit c0ebd6a into DynamoDS:RC2.5.0_master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants