Skip to content

Remove LibG223 dir, add support for LibG for ASM226 #10146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aparajit-pratap merged 2 commits into from
Nov 20, 2019
Merged

Remove LibG223 dir, add support for LibG for ASM226 #10146

aparajit-pratap merged 2 commits into from
Nov 20, 2019

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Nov 19, 2019 •
edited
Loading

Purpose

Remove support for LibG for ASM223.

TODO: Cherry-pick into RC2.5 once self-serve passes.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner @reddyashish

FYIs

@DynamoDS/dynamo

@aparajit-pratap aparajit-pratap changed the title remove LibG223 dir [WIP] remove LibG223 dir Nov 19, 2019
@aparajit-pratap aparajit-pratap changed the title [WIP] remove LibG223 dir Remove LibG223 dir, add support for LibG for ASM226 Nov 19, 2019
@mjkkirschner
Copy link
Member

mjkkirschner commented Nov 19, 2019

@aparajit-pratap thanks - I actually just filed this as a task - did you run the tests to see if any fail? (libG loading ones?)

@mjkkirschner mjkkirschner added this to the 2.5.0 milestone Nov 20, 2019
@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Nov 20, 2019

Surprisingly see one self-serve excel test fail 😕

@aparajit-pratap aparajit-pratap merged commit ccf153d into DynamoDS:master Nov 20, 2019
@aparajit-pratap aparajit-pratap deleted the removeLibg223 branch November 20, 2019 18:48
aparajit-pratap added a commit to aparajit-pratap/Dynamo that referenced this pull request Nov 20, 2019
@aparajit-pratap
Remove LibG223 dir, add support for LibG for ASM226 (DynamoDS#10146)
69061b4 
* remove LibG223 dir

* add support for LibG for ASM226, remove 223 references from code
@aparajit-pratap aparajit-pratap mentioned this pull request Nov 20, 2019
Merged
7 tasks
aparajit-pratap added a commit that referenced this pull request Nov 20, 2019
@aparajit-pratap
Cherry-pick #10146 - remove libg223, add support for asm226 (#10152)
245b0dd 
* Remove LibG223 dir, add support for LibG for ASM226 (#10146)

* remove LibG223 dir

* add support for LibG for ASM226, remove 223 references from code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

WIP

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@aparajit-pratap @mjkkirschner