fix: Changes are no longer detected when start and end time are left empty in tmpo edit
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the edit command to compare StartTime and EndTime fields with minute-level precision by truncating to the nearest minute. This prevents false positives when only sub-minute differences exist, aligning with the precision of parseDateTime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
mainbranch of tmpo.Closes #31
Description
This pull request improves the accuracy of change detection in the entry editing command by ensuring time comparisons only consider minute-level precision. This prevents false positives when comparing timestamps that may have different second or sub-second values but are otherwise equivalent at the minute level.
Key changes:
Time comparison precision:
EditCmdcommand to truncate both the original and edited start and end times to the nearest minute before checking for changes, ensuring only meaningful differences are detected.Dependency update:
timepackage import incmd/entries/edit.goto support time truncation operations.