Skip to content

Implementation of invariant for capturing information from branching#6

Merged
Dudeldu merged 2 commits intomasterfrom
invariant-impl
Jun 9, 2022
Merged

Implementation of invariant for capturing information from branching#6
Dudeldu merged 2 commits intomasterfrom
invariant-impl

Conversation

@Dudeldu
Copy link
Copy Markdown
Owner

@Dudeldu Dudeldu commented May 29, 2022

This allows to make use of information coming from branching e.g.:

if (a == 1.)
{
    assert(a == 1.); // SUCCESS!
}

One conceptional problem occurs once again here, that a user can not directly specify a range. Even code like if (0. < a && a < 5), does not bound the interval, as the value always could as well be top. In addition both conditions are evaluated one after the other, which makes it impossible to take both "ending" values into account simultaneously. Therefore, all sub-evaluations as well as the last one result in top. The only way to prevent this, is actually assigning different double values inside different branches to make the interval span the contained range.

@Dudeldu Dudeldu force-pushed the invariant-impl branch 2 times, most recently from a78d61e to 24018b6 Compare May 31, 2022 14:55
@Dudeldu Dudeldu changed the title WIP: Implementation of invariant for capturing information from branching Implementation of invariant for capturing information from branching May 31, 2022
@Dudeldu Dudeldu requested review from FelixKrayer, brgr and iheathrow May 31, 2022 15:11
Copy link
Copy Markdown
Collaborator

@FelixKrayer FelixKrayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I fully understand what happens in base.ml... but if it works it might be fine

@Dudeldu
Copy link
Copy Markdown
Owner Author

Dudeldu commented Jun 4, 2022

I will give you a summary on how this works exactly on thursday in favour of distributing the knowledge among all of us

@Dudeldu Dudeldu requested a review from FelixKrayer June 4, 2022 07:29
Copy link
Copy Markdown
Collaborator

@FelixKrayer FelixKrayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

@brgr brgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :-)

@Dudeldu Dudeldu merged commit 02d81db into master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants