n64tool: return error in case the seek offset required backward seek.#144
Merged
DragonMinded merged 1 commit intoDragonMinded:trunkfrom Jun 24, 2021
Merged
Conversation
For instance, if the user asks to put a DFS at 1M, but the code/data is 2M, it simply can't be done. Instead of silently putting the DFS at 2M, better return an error and let the user handle it, especially since the seek offset needs to be passed to dfs_init() so the user needs to be aware of the correct value. Fixes DragonMinded#141
anacierdem
added a commit
to anacierdem/libdragon-docker
that referenced
this pull request
Jul 27, 2021
Changed - Improve fastpath of dfs_read (DragonMinded/libdragon#133) - Refactor n64tool (DragonMinded/libdragon#153, DragonMinded/libdragon#155) Fixed - Zero-initialize the token array to avoid -Werror=maybe-uninitialized (DragonMinded/libdragon#134) - Initialize arguments to main libdragon entrypoint (DragonMinded/libdragon#136) - SD support fixes and dragonfs fopen fix (DragonMinded/libdragon#137) - lib/include paths in tests Makefile (DragonMinded/libdragon#138) - Reenable test_timer_ticks for emulators (DragonMinded/libdragon#140) - n64tool: return error in case the seek offset required backward seek (DragonMinded/libdragon#144) - Add missing extern "C" in debug.h (DragonMinded/libdragon#146) - Ensure C++ global constructors are not garbage collected by ld (DragonMinded/libdragon#148) - Fix clipped RDP rectangle drawing (DragonMinded/libdragon#147) Added - restart_timer and new_timer_stopped functions (DragonMinded/libdragon#131) - dfs_rom_addr (DragonMinded/libdragon#133) - Implement EEPROM Filesystem and test ROM (DragonMinded/libdragon#125) - ed64romconfig binary (DragonMinded/libdragon#153, DragonMinded/libdragon#155) - Support for RTC status/read/write commands (DragonMinded/libdragon#152)
anacierdem
added a commit
to anacierdem/libdragon-docker
that referenced
this pull request
Jul 27, 2021
Changed - Improve fastpath of dfs_read (DragonMinded/libdragon#133) - Refactor n64tool (DragonMinded/libdragon#153, DragonMinded/libdragon#155) - It no longer support byte-swapping and only generates a z64 file. Fixed - Zero-initialize the token array to avoid -Werror=maybe-uninitialized (DragonMinded/libdragon#134) - Initialize arguments to main libdragon entrypoint (DragonMinded/libdragon#136) - SD support fixes and dragonfs fopen fix (DragonMinded/libdragon#137) - lib/include paths in tests Makefile (DragonMinded/libdragon#138) - Reenable test_timer_ticks for emulators (DragonMinded/libdragon#140) - n64tool: return error in case the seek offset required backward seek (DragonMinded/libdragon#144) - Add missing extern "C" in debug.h (DragonMinded/libdragon#146) - Ensure C++ global constructors are not garbage collected by ld (DragonMinded/libdragon#148) - Fix clipped RDP rectangle drawing (DragonMinded/libdragon#147) Added - restart_timer and new_timer_stopped functions (DragonMinded/libdragon#131) - dfs_rom_addr (DragonMinded/libdragon#133) - Implement EEPROM Filesystem and test ROM (DragonMinded/libdragon#125) - ed64romconfig binary (DragonMinded/libdragon#153, DragonMinded/libdragon#155) - Support for RTC status/read/write commands (DragonMinded/libdragon#152)
anacierdem
added a commit
to anacierdem/libdragon-docker
that referenced
this pull request
Jul 28, 2021
Changed - Removed make, download, init, buildDragon, prepareDragon, and installDependencies NPM scripts - Update the necessary vscode and travis configuration - Update the readme to match - this also fixes #31 - Improve fastpath of dfs_read (DragonMinded/libdragon#133) - Refactor n64tool (DragonMinded/libdragon#153, DragonMinded/libdragon#155) - It no longer support byte-swapping and only generates a z64 file. - Change test bench Makefile to reflect latest changes Fixed - Zero-initialize the token array to avoid -Werror=maybe-uninitialized (DragonMinded/libdragon#134) - Initialize arguments to main libdragon entrypoint (DragonMinded/libdragon#136) - SD support fixes and dragonfs fopen fix (DragonMinded/libdragon#137) - lib/include paths in tests Makefile (DragonMinded/libdragon#138) - Reenable test_timer_ticks for emulators (DragonMinded/libdragon#140) - n64tool: return error in case the seek offset required backward seek (DragonMinded/libdragon#144) - Add missing extern "C" in debug.h (DragonMinded/libdragon#146) - Ensure C++ global constructors are not garbage collected by ld (DragonMinded/libdragon#148) - Fix clipped RDP rectangle drawing (DragonMinded/libdragon#147) - Enable byte swap flag for the make action and update documentation accordingly - Skip the second parameter to the libdragon command as well - Enable --byte-swap flag for the make action Added - restart_timer and new_timer_stopped functions (DragonMinded/libdragon#131) - dfs_rom_addr (DragonMinded/libdragon#133) - Implement EEPROM Filesystem and test ROM (DragonMinded/libdragon#125) - ed64romconfig binary (DragonMinded/libdragon#153, DragonMinded/libdragon#155) - Support for RTC status/read/write commands (DragonMinded/libdragon#152) - Generic libdragon NPM script
anacierdem
added a commit
to anacierdem/libdragon-docker
that referenced
this pull request
Jul 28, 2021
Changed - Removed make, download, init, buildDragon, prepareDragon, and installDependencies NPM scripts - Update the necessary vscode and travis configuration - Update the readme to match - this also fixes #31 - Improve fastpath of dfs_read (DragonMinded/libdragon#133) - Refactor n64tool (DragonMinded/libdragon#153, DragonMinded/libdragon#155) - It no longer support byte-swapping and only generates a z64 file. - Change test bench Makefile to reflect latest changes Fixed - Zero-initialize the token array to avoid -Werror=maybe-uninitialized (DragonMinded/libdragon#134) - Initialize arguments to main libdragon entrypoint (DragonMinded/libdragon#136) - SD support fixes and dragonfs fopen fix (DragonMinded/libdragon#137) - lib/include paths in tests Makefile (DragonMinded/libdragon#138) - Reenable test_timer_ticks for emulators (DragonMinded/libdragon#140) - n64tool: return error in case the seek offset required backward seek (DragonMinded/libdragon#144) - Add missing extern "C" in debug.h (DragonMinded/libdragon#146) - Ensure C++ global constructors are not garbage collected by ld (DragonMinded/libdragon#148) - Fix clipped RDP rectangle drawing (DragonMinded/libdragon#147) - Enable byte swap flag for the make action and update documentation accordingly - Skip the second parameter to the libdragon command as well - Enable --byte-swap flag for the make action Added - restart_timer and new_timer_stopped functions (DragonMinded/libdragon#131) - dfs_rom_addr (DragonMinded/libdragon#133) - Implement EEPROM Filesystem and test ROM (DragonMinded/libdragon#125) - ed64romconfig binary (DragonMinded/libdragon#153, DragonMinded/libdragon#155) - Support for RTC status/read/write commands (DragonMinded/libdragon#152) - Generic libdragon NPM script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For instance, if the user asks to put a DFS at 1M, but the code/data is
2M, it simply can't be done. Instead of silently putting the DFS at 2M,
better return an error and let the user handle it, especially since
the seek offset needs to be passed to dfs_init() so the user needs
to be aware of the correct value.
Fixes #141