Skip to content

fixup build process to better support front-end packages#6

Merged
Dosant merged 3 commits intoDosant:d/2021-10-06-try-extract-component-from-kibana-reactfrom
spalger:pr/114129
Oct 12, 2021
Merged

fixup build process to better support front-end packages#6
Dosant merged 3 commits intoDosant:d/2021-10-06-try-extract-component-from-kibana-reactfrom
spalger:pr/114129

Conversation

@spalger
Copy link
Copy Markdown

@spalger spalger commented Oct 7, 2021

misc cleanup of the copied package for the purpose of creating a front-end package which can be imported in node (for Jest compatibility) and from front-end bundles built with Webpack.

This modifies the jsts_transform function to pass babel the --copy-files argument so that it will ignore assets selected in SRCS and just write them to the output directory. The target_node is built in a way that should be compatible with Jest, and the target_webpack directory is built in a way that should be compatible with Webpack.

Spencer and others added 2 commits October 7, 2021 21:34
Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
@Dosant Dosant merged commit ec391e2 into Dosant:d/2021-10-06-try-extract-component-from-kibana-react Oct 12, 2021
@spalger spalger deleted the pr/114129 branch October 12, 2021 14:07
Dosant pushed a commit that referenced this pull request Apr 28, 2022
Dosant pushed a commit that referenced this pull request Sep 17, 2025
…de API (elastic#234571)

**Partially resolves: elastic#140369**

## Summary

This is another PR from of a series of PRs I am planning to create to
cover the requirements in the elastic#140369 ticket.

The requirement covered in this ticket is req. #6: "Events for
performing update (EBT backend)" and req. #7 "Missing base versions".

I am adding sending telemetry events in handling of rule update request.
Each rule updated will send its own event with information about:
- ruleId
- ruleName
- if missing base version
- final result of the update
- updated fields (with breakdown per conflict type). 

I tried to make the changes as little invasive as possible, and decided
to create a separate file, `update_rule_telemetry.ts`, where the logic
of building the events and sending them is encapsulated.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants