fix: add offsets to auto scroll row values to prevent scrolling when reaching first and last row#368
Merged
Gumball2415 merged 4 commits intoDn-Programming-Core-Management:mainfrom Aug 6, 2025
Conversation
Contributor
Author
|
Also noticed my commit messages are removed (the part after fix: ), not sure what's up with that... |
Collaborator
|
side note: should the last two rows be also selectable? currently (since vanilla), selecting the last two rows also triggers scrolling. |
Contributor
Author
|
Sure, I increased the offset at the bottom by 4 rows, this should allow for selecting the last visible rows with some leeway for sloppy selections. |
Collaborator
|
lgtm, merging soon |
Gumball2415
reviewed
Aug 6, 2025
Gumball2415
added a commit
that referenced
this pull request
Aug 6, 2025
This addresses a comment in #368. This enables building on computers with non-English system locales.
Gumball2415
added a commit
that referenced
this pull request
Aug 9, 2025
This addresses a comment in #368. This enables building on computers with non-English system locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to change auto scroll to not scroll when dragging to row 0 and the last row to make row 0 and the last row selectable. This is done by adding a -1 offset to the auto scroll row value for
SCROLL_UPand adding a +1 offset to to the auto scroll row value forSCROLL_DOWN.Right now this happens:
After this PR:
It is still possible to scroll to the previous rows but only above row 0 which makes row 0 actually selectable. The same is true for the last row.
This PR also adds
/utf-8in the build additional options to make building possible on Windows computers with Japanese system codes.fixes #351
Changes in this PR:
/utf-8to build additional options to make building possible on Windows computers with Japanese system codes