CI: Add Portable plugin install to release #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove windows-installer in build folder if exists
Collaborator
Author
|
To test on windows : IF so : edit line 36 in installer-Windows.iss.in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since changes with the OBS plugin-template, the default installation and packaging of the plugin have evolved and cannot be use easily for OBS portable (on Windows).
This PR aim to resolve this by providing a portable variant compatible with OBS portable installs.
Changes that created this issue :
Based on the great work of @CodeYan01 Following the issue raised on the OBS Plugin-template : obsproject/obs-plugintemplate#143
There are also some update on the way to upload the installer artifact (that might be dropped for clarity)
Address the problem reported at : #1283
The plugin files tree is different based on the install:
Manual (& Installer) plugin install
C:\ProgramData\obs-studio\plugins\distroav
(Actually using :
{commonappdata}\obs-studio\plugins\{#MyProjectName})|-distroav
|--bin
|---64bit
|----distroav.dll
|----distroav.pdb
|--data
|---locale
|----all the .ini language files
Expected plugin files tree on portable obs
obs-studio
|-obs-plugins
|--bin
|---64bit
|----distroav.dll
|----distroav.pdb
|--data
|---obs-plugins
|----distroav
|-----locale
|------all the .ini language files