Skip to content

Conversation

@Trouffman
Copy link
Collaborator

@Trouffman Trouffman commented Feb 5, 2025

This aim to use the updated OBS Plugin Template.

There are a major lack of documentation about the changes and this process is highly manual.

Goal is:

  • Update and be as close as possible to default plugin (to avoid having the same challenges at next update)
  • Get things to compile (at least on github), preferably locally too for dev purposes.

No other changes should be made as well (no new features / bug fix etc).

There are a bunch of changes that would impact the obs_log but this is too complex and will be dealt in another PR once this is merged.

Impacts:

This could be re-implemented via specific PR is relevant.

@Trouffman Trouffman added the Seeking Testers PRs with this label will package the plugin so that others can test label Feb 5, 2025
@Trouffman Trouffman self-assigned this Feb 5, 2025
@Trouffman Trouffman marked this pull request as ready for review February 6, 2025 17:53
@Trouffman
Copy link
Collaborator Author

This is ready for review / testing.

There are a LOT of changes, including changes to default github actions and code formatting process.

please check the latest artefacts and try on your system, report any bug that are not in master branch,

@Trouffman Trouffman added obs-plugintemplate Installation Target installation improvments, issues, scripts, bugs. Build relate to building issues (all platform) labels Feb 6, 2025
@Trouffman Trouffman changed the title WIP - Update with OBS Template Update with OBS Template Feb 7, 2025
@Trouffman
Copy link
Collaborator Author

This is no longer. WIP and should be tested on the major OS.

@Trouffman
Copy link
Collaborator Author

This requires OBS 31.

there are some possible clean-up to be pushed as well later with the work on the new config files

@Trouffman
Copy link
Collaborator Author

An Important point on this PR:

The obs-plugintemplate moved away from providing & maintaining build script for innosetup outside of the CI environment.

This brings us to a choice:

  • Figure out and maintain a full innosetup build system that (realistically) only us will us. This could help on integrating "helpers" like removing old versions (obs-ndi) - which will not be part of the automated release/ build etc. realistically only for testing.

-or-

  • (preferred) Stick as close as possible to the plugin-template and stop using the innosetup this will block/impact a couple of recent planned features (clean-up of old Obs-ndi // trigger firewall open)

Planned features could be implemented at:

  • Set our "requirements" at module_load, disable the plugin is requirements are not met.
  • Script to clean-up older obs-ndi files. (this is realistically a shrinking number of users (was more of a challenge on v6 release
  • Script to help setting the Firewall (on multiple systems) - This should "request" the firewall prompt from the OS whenever available

@Trouffman Trouffman requested review from RayneYoruka and paulpv and removed request for paulpv February 10, 2025 02:46
@Trouffman Trouffman merged commit 5d781bc into master Feb 10, 2025
6 checks passed
@Trouffman Trouffman deleted the obs_31_min_req_update branch February 10, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build relate to building issues (all platform) Installation Target installation improvments, issues, scripts, bugs. obs-plugintemplate Seeking Testers PRs with this label will package the plugin so that others can test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants