-
-
Notifications
You must be signed in to change notification settings - Fork 419
Delete obs-ndi plugin on macos after installing DistroAV #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will be testing this for Mac OS. |
|
This will NOT remove files in the system library as this is "offlimit" for scripts. |
So why does it even try? |
|
Who has a problem with this? |
Couple things there :
You review is important, we could only target the OBS-ndi files in the user ~/Library. Note that there is another PR adding the path of the detected OBS-ndi that should help most requests. This was the main source for support requests coming in the last weeks as in "I followed the install instructions but it still says it's there". |
|
Understood. Just seems like a lot of work for "a few" users. Still, it is nice to have I guess. I just wouldn't want it to cause more problems than it is trying to fix. I wouldn't want it to fix a problem for 3 users [that can't/won't read/follow directions] but cause a problem for hundreds. |
|
I would still like to move the |
|
@BitRate27 I see that the postinstall & script folder is not being deleted after distroav install. I am not keen on creating garbage files, we should revisit this approach. |
|
Thanks! Will not be able to look at this until Dec 2. |
Users were instructed to manually delete the obs-ndi.plugin from obs-studio before installing DistroAV. This proved to be a challenge for some users and is prone to user error. With this PR, the deletion of the old plugin is done automatically as part of the installation of the DistroAV plugin.
Target Usage:
The PR solves this issue by:
Testing: